1355473 - convert uses of "defer" to "new Promise" in client/responsivedesign

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P3)

Description

[Anirban Biswas]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Comment 1

[Anirban Biswas]

Attachment: patch for responsivedesign directory

I have done the necessary changes for responsivedesign directory. Please have a look at this and let me know whether its okay to push it.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Anirban Biswas from comment #1)
> Created attachment 8859272 [details] [diff] [review]
> patch for responsivedesign directory
> 
> I have done the necessary changes for responsivedesign directory. Please
> have a look at this and let me know whether its okay to push it.

Hmm, it seems like your patch contains many unrelated changes, perhaps from when you pulled in new changes?

If you are using Mercurial, perhaps the guide[1] can help here.  You can also ask for help on IRC in #devtools or #introduction.

[1]: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial

Comment 3

[Matt R [:stylizit] (slow, away until Sep)]

Attachment: Bug 1355473 - convert uses of 'defer' to 'new Promise' in client/responsivedesign;

Review commit: https://reviewboard.mozilla.org/r/141362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141362/

Comment 4

[Tom Tromey :tromey]

Comment on attachment 8869810 [details]
Bug 1355473 - convert uses of 'defer' to 'new Promise' in client/responsivedesign;

https://reviewboard.mozilla.org/r/141362/#review146470

Thanks for the patch.  This looks good.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79fcc56007c1
convert uses of 'defer' to 'new Promise' in client/responsivedesign; r=tromey

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79fcc56007c1