add "view diff" button to Release Scheduled Changes UI

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: bhearsum, Assigned: collins.abitekaniza)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][lang=html][ready])

When reviewing a scheduled change to a Release it would be helpful to be able to see what is changing vs the current version of the object. Without it, most blobs are too big to review in a useful way.

A diff, similar to what we do in the Releases History UI, is likely the best way to show this. It's only needed for change_type "update" (inserts are an entirely new blob, and deletes remove an entire blob).

This may need some backend support to generate the required diff.

Comment 1

2 years ago
++
Comment hidden (typo)
Comment hidden (typo)
Comment hidden (typo)
Mentor: bhearsum
Priority: P2 → P3
Mentor: bhearsum

Updated

a year ago
Assignee: nobody → rachael.njeri

Comment 5

a year ago
@bhearsum my understanding of this bug fix is to have a "diff" button that shows current vs previous data.
As suggested earlier the bug fix should have an implementation similar to the history ui but when i check at this ui i cannot see how it was implemented...Am i missing something.Please clarify..
if possible could we have a sync call for this?

Comment 6

a year ago
@bhearsum i managed to replicate the history ui.Finally understood how to implement it.thanks

Updated

a year ago
Assignee: rachael.njeri → alvin.mutisya
(Assignee)

Updated

10 months ago
Assignee: alvin.mutisya → collins.abitekaniza

Comment 7

10 months ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6c22b974b95069127fee14697f7a7f80dc820f3b
bug 1355477: View Diff in Scheduled Release updates (#447). r=bhearsum
(Reporter)

Updated

8 months ago
Depends on: 1461956
Now in production, thanks Collins!
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
(Assignee)

Comment 9

8 months ago
(In reply to Ben Hearsum (:bhearsum) from comment #8)
> Now in production, thanks Collins!

You're welcome :)
You need to log in before you can comment on or make changes to this bug.