ExternalProtocolHandler should use standard not simple uri

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
17 years ago
15 years ago

People

(Reporter: mkaply, Assigned: mscott)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
I'm currently implementing protocol handling for OS/2 (and soon for unix)

In order to support things like telnet:user:password@host.com, we need the 
ability to parse the URIs.

Unfortunately, currently the helper app protocol uses a SimpleURI so we don't 
get the parsing for free.

I was able to change it to a standard url and it worked.

Patch attached.

What the heck is the difference betweek a URL and a URI anyway?
(Reporter)

Comment 1

17 years ago
Created attachment 77747 [details] [diff] [review]
Change simple URI to standard URL
(Reporter)

Comment 2

17 years ago
Boris, what do you think of this one?
I think you should get Darin or someone else familiar with URI parsing to
comment... :)

Comment 4

17 years ago
Comment on attachment 77747 [details] [diff] [review]
Change simple URI to standard URL

mkaply: you might take a look at nsIStandardURL... there's an Init method which
is similar to SetSpec, but it also allows you to customize the parsing a little
bit.

the difference between an URL and an URI is simple.  an URI doesn't have any
concept of a file path, query string, or reference fragment.  where as an URL
does.
(Reporter)

Comment 5

17 years ago
Actually, switching to StandardURL is what I want to do here.

In the helper application, we need a lot more info than just a URI gives.
(Reporter)

Comment 6

15 years ago
I just added code in nsOSHelperAppService.cpp to change to a StandardURL so I
get get the info I need.

See:

http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/os2/nsOSHelperAppService.cpp#1254

I don't think this change for everyone is necessary.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.