1355520 - Headset plugging/unplugging blocks the media from playback

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

[Affected versions]:
Firefox 52.1.0esr (Build Id:20170410145022)
Firefox 53.0b10(Build Id:20170407033734)

[Unaffected versions]:
Firefox 54.0a2 (Build Id:20170410004019)
Firefox 55.0a1 (Build Id:20170410030221)

[Affected platforms]:
Mac 10.11.6

[Steps to reproduce]:
1.Launch Firefox.
2.Access the https://www.youtube.com/watch?v=ymNFyxvIdaM weblink.
3.Press the Pause button.
4.Unplug headphones.
5.Plug headphones.
6.Click the Play button.
7.Observe that media gets stuck and no longer plays.

[Expected result]:
The video continues to play.

[Actual result]:
The media gets stuck and no longer plays even if switching to another video.

[Regression range]:
I will come back with a regression range asap, if any.

[Additional information]:
Please access the following link: https://drive.google.com/open?id=0B94iuIVMr-TEcktkZjdpc1dpSE0 in order to observe the issue.

Please note that you may need to repeat steps 3, 4 and 5 a couple of times in order to reproduce this issue.

Comment 1

[Jim Mathies [:jimm]]

Maire, can you help us triage this?

Comment 2

[Alex Chronopoulos [:achronop]]

Jim, Maire is on PTO, I will take it. Thanks

Comment 3

[Alex Chronopoulos [:achronop]]

I try to repro in 53.0b10 (Mac 10.11.6) but not possible. Can you please capture logs. Please use flags "MediaStreamGraph:4,cubeb:4"

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Seems intermittent, we don't have anything solid here to work with yet. Wontfix for 53.

Comment 5

[Emil Ghitta, QA [:emilghitta]]

Attachment: log.txt.child-1.0

Hi Alex,

I have reproduced the issue with Firefox 53.0 (Build Id:20170413192749).

I have also attached the requested log file.

I have observed that you have to be pretty quick (to unplug/plug the headphones as soon as the video starts loading) in order to reproduce this issue with ease.

Please needinfo me if you have further questions.

Comment 6

[Alex Chronopoulos [:achronop]]

52 ESR try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=299e9aa5b90cd629342bd671f8bb8aa9ab599dee

Comment 7

[Alex Chronopoulos [:achronop]]

Can you please verify if the following custom build solve the issue: https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-299e9aa5b90cd629342bd671f8bb8aa9ab599dee/try-macosx64/firefox-52.1.1.en-US.mac.dmg

Comment 8

[Emil Ghitta, QA [:emilghitta]]

Hi Alex!

Unfortunately, the issue is still reproducible with the custom build that you provided in comment 7.

Comment 9

[Alex Chronopoulos [:achronop]]

Thanks! Can you please provide logs?

Comment 10

[Emil Ghitta, QA [:emilghitta]]

Attachment: log01.txt.0

My mistake (I forgot to attach the log).

Comment 11

[Alex Chronopoulos [:achronop]]

Hmm that's strange can you please provide verbose logs: cubeb:5

Comment 12

[Emil Ghitta, QA [:emilghitta]]

Attachment: log12.txt (1).0

Comment 13

[Alex Chronopoulos [:achronop]]

New esr52 try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f302db5ebd8fa8073f2c9abd793850209e718336

Comment 14

[Alex Chronopoulos [:achronop]]

Can you please verify if the following build solves the issue:
https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-f302db5ebd8fa8073f2c9abd793850209e718336/try-macosx64/firefox-52.1.1.en-US.mac.dmg

Comment 15

[Blake Wu [:bwu][:blakewu]]

FWIW, I can reproduce this bug easily on my Windows 10 Laptop (Dell XPS15) with Logitech USB Headset H340 on the latest nightly, 550a1 (2017-05-02) (32-bit).

Comment 16

[Alex Chronopoulos [:achronop]]

Can you check if the same error occurs for wasapi backend?

Comment 17

[Paul Adenot (:padenot)]

Blake, I works fine here on nightly, can you get me logs ?

What I've tried:
- Get a Lenovo thinkpad w530, with a USB headset (plantronics 648) plugged in
- Open Nightly
- Open a youtube video
- it plays, sound is coming of the plantronics headset
- unplug the plantronics headset
- it now plays on the laptop's speaker
- re-plug the plantronics headset
- it now plays on the headset

I also tried plugging and unplugging quite fast, but I have the same results.

Comment 18

[Blake Wu [:bwu][:blakewu]]

I still can see this problem on the latest nightly, 55.0a1 (2017-05-04) (32 bit), on my Dell XPS15 with Logitech USB Headset H340.
IIRC, Chunmin and I saw this problem when we checking bug 1361336 yesterday.
Chunmin, 
Can you help on comment 16?

Comment 19

[C.M.Chang[:chunmin]]

I cannot reproduce it on my PC. I'll try it upon I get my Windows laptop.

Comment 20

[Emil Ghitta, QA [:emilghitta]]

Hi Alex! 

It seems that this issue is fixed in the build that you provided on comment 14.

Sorry for the delay!

Comment 21

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1355520 - Unregister system listener on destroy to avoid collisions. r?kinetik

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: No
User impact if declined: Media playback stop permanenten after plug-unplug external headset. 
Fix Landed on Version:Error appears only in esr 52 and release
Risk to taking this patch (and alternatives if risky): No risk easy patch, part of the patch is landed in Nightly
String or UUID changes made by this patch: 

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 22

[Matthew Gregan [:kinetik]]

Comment on attachment 8867720 [details]
Bug 1355520 - Unregister system listener on destroy to avoid collisions. r?kinetik

OK for the actual changes given they're reviewed/tested upstream and in nightly, but:

To make review easier, can you be specific which commit (hashes) are being uplifted here?  It looks like e5e8e812cd369018318ac282006cc3182b549a08 and 4bf03c2bb6ea0f8c8a0798b59f35edf62c02ffd0 merged together?

Please create a .patch file and add it to update.sh before this is committed.  I'll r- for now due to this, otherwise a+ will cause this to be landed by a sheriff.

Comment 23

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1355520 - Unregister system listener on destroy to avoid collisions. r?kinetik

For approve request please see comment 21.

Comment 24

[Alex Chronopoulos [:achronop]]

The patch is a combination of the following github commits on cubeb repo:

dd746a33bd1dba207996337035b59ae0b29e9fc5
4bf03c2bb6ea0f8c8a0798b59f35edf62c02ffd0
e5e8e812cd369018318ac282006cc3182b549a08 (older)

Comment 25

[Julien Cristau [:jcristau]]

Alex, can you clarify the status for this on beta?

Comment 26

[Alex Chronopoulos [:achronop]]

Bug is reported only in esr52 and release.

Comment 27

[Julien Cristau [:jcristau]]

Comment on attachment 8868645 [details] [diff] [review]
Bug 1355520 - Unregister system listener on destroy to avoid collisions. r?kinetik

cubeb fixes for esr52.

Emil, can you verify the fix after it lands?  Having verification some time in the next week or two would be great.

Comment 28

[Julien Cristau [:jcristau]]

I fail at ni?.  See comment 27.

Comment 29

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/7ca2d8839f7a

Comment 30

[Emil Ghitta, QA [:emilghitta]]

I have verified that this issue is not reproducible anymore using Firefox 52.2.0 esr (Build Id:20170607123825) on macOS 10.11.6 and macOS 10.12.1.