1355586 - ./mach package doesn't work for MinGW builds

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

It would be nice if ./mach package worked for cross-compilation MinGW builds to enable easy testing.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Besides the NSIS issue, as stated in https://bugzilla.mozilla.org/show_bug.cgi?id=1314979#c21 mingw builds on windows may not configure successfully and we might want to refactor our checks for it.

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1355586 Support makensis on MinGW Linux for Windows builds

This involves a few changes:
- Move makensis above makensis.exe because on Linux, nsis also
  builds makensis.exe which isn't going to run
- Doesn't bother checking if nsis is 32bit if we're running on
  Linux
- Add the -nocd option to nsis (on Linux) because it takes the
  current working directory from the target of a symlink rather
  than the symlink itself. See
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704828

Review commit: https://reviewboard.mozilla.org/r/142838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142838/

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8871363 [details]
Bug 1355586 Support makensis on MinGW Linux for Windows builds

The patch I am marking obsolete does address some components of this bug, but is really designed to specifically address Bug 1367847

Comment 4

[Mike Hommey [:glandium]]

I'm not sure since when, but mingw-clang builds have had mach package running for a while.

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Hah; I think I assumed that it was failing because setup.exe was tiny and non-functioning; but it seems that it is the same on the regular windows builds too!