1355602 - Allow pushing a stacking context without a corresponding scroll layer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now wr_dp_push_stacking_context automatically also pushes a scroll layer. This seems unnecessary; the caller might just want a stacking context without the scroll layer. In particular for APZ I think we're only going to need the scroll layers for.. scrolling layers.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1355602 - Decouple pushing scroll layers from pushing stacking contexts.

This removes the call to push_scroll_layer in wr_push_stacking_context, so that
it's now possible to push a stacking context without necessarily pushing a
scroll layer. There is already a separate function to push a scroll layer so the
call sites can do that. This patch just changes all the call sites that were
pushing a stacking context to also push a scroll layer, so there should be no
functional change. Future patches can remove of the spurious scroll layers.

Review commit: https://reviewboard.mozilla.org/r/129112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129112/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=37bf19b27223c9202f82fc39b5b0235ce325ee22 includes this patch

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8857168 [details]
Bug 1355602 - Decouple pushing scroll layers from pushing stacking contexts.

https://reviewboard.mozilla.org/r/129112/#review131598

::: gfx/webrender_bindings/src/bindings.rs:780
(Diff revision 1)
>      gl.clear_color(0.3, 0.0, 0.0, 1.0);
>  
>      let version = gl.get_string(gl::VERSION);
>  
>      println!("WebRender - OpenGL version new {}", version);
> +    writeln!(::std::io::stderr(), "[stderr] WebRender starting up, yo").unwrap();

Not sure if you meant for this to be here, but we can keep it if you want.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I put this in. I'm happy to see it go.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > +    writeln!(::std::io::stderr(), "[stderr] WebRender starting up, yo").unwrap();
> 
> Not sure if you meant for this to be here, but we can keep it if you want.

Whoops, that wasn't meant to be there. I was trying to figure out how to get console output on Windows. (No success yet).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/c340f45623ab
Decouple pushing scroll layers from pushing stacking contexts. r=jrmuizel

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/c340f45623ab