Closed Bug 1355602 Opened 4 years ago Closed 4 years ago

Allow pushing a stacking context without a corresponding scroll layer

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Right now wr_dp_push_stacking_context automatically also pushes a scroll layer. This seems unnecessary; the caller might just want a stacking context without the scroll layer. In particular for APZ I think we're only going to need the scroll layers for.. scrolling layers.
Comment on attachment 8857168 [details]
Bug 1355602 - Decouple pushing scroll layers from pushing stacking contexts.

https://reviewboard.mozilla.org/r/129112/#review131598

::: gfx/webrender_bindings/src/bindings.rs:780
(Diff revision 1)
>      gl.clear_color(0.3, 0.0, 0.0, 1.0);
>  
>      let version = gl.get_string(gl::VERSION);
>  
>      println!("WebRender - OpenGL version new {}", version);
> +    writeln!(::std::io::stderr(), "[stderr] WebRender starting up, yo").unwrap();

Not sure if you meant for this to be here, but we can keep it if you want.
Attachment #8857168 - Flags: review+
Attachment #8857168 - Flags: review?(mchang)
I put this in. I'm happy to see it go.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > +    writeln!(::std::io::stderr(), "[stderr] WebRender starting up, yo").unwrap();
> 
> Not sure if you meant for this to be here, but we can keep it if you want.

Whoops, that wasn't meant to be there. I was trying to figure out how to get console output on Windows. (No success yet).
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/c340f45623ab
Decouple pushing scroll layers from pushing stacking contexts. r=jrmuizel
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.