1355615 - Make wr_api_finalize_builder take pointers instead of references

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

The Rust side of wr_api_finalize_builder takes &mut args [1], but the C++ side [2] passes in a pointer for one argument and references for the rest. Not friendly to binding generator, so let's convert them all to pointers. I'm actually not sure if it's FFI-safe to be taking &mut at all on the rust side, but it seems to be working ok so far so we can leave it be. If we want to change it later it will be easier once the binding generator is plugged in.

[1] http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/gfx/webrender_bindings/src/bindings.rs#1326-1330
[2] http://searchfox.org/mozilla-central/rev/624d25b2980cf5f83452b040e6d664460f9b7ec5/gfx/webrender_bindings/webrender_ffi.h#713-717

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54ce95331f4dd417027cc85cd350a946ddfabb77

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1355615 - Update wr_api_finalize_builder to take pointers on the C++ side to match the Rust side.

Review commit: https://reviewboard.mozilla.org/r/129138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129138/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8857205 [details]
Bug 1355615 - Update wr_api_finalize_builder to take pointers on the C++ side to match the Rust side.

https://reviewboard.mozilla.org/r/129138/#review131636

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/2e8731eba019
Update wr_api_finalize_builder to take pointers on the C++ side to match the Rust side. r=jrmuizel

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/2e8731eba019