Closed
Bug 1355617
Opened 7 years ago
Closed 7 years ago
MPEG4Extractor.cpp warnings: implicit conversion from enum to int
Categories
(Core :: Audio/Video: Playback, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
Details
Attachments
(1 file)
Noticed while building locally:
> media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp:630:12: warning:
> implicit conversion from 'stagefright::(anonymous enum at media/libstagefright/system/core/include/utils/Errors.h:45:1)'
> to 'status_t' (aka 'int') changes value from 2147483648 to -2147483648 [-Wconstant-conversion]
> return UNKNOWN_ERROR; // Return a dummy error.
> ~~~~~~ ^~~~~~~~~~~~~
Also at lines 848 and 1982.
Not critical I think, but it would be nice to remove ugly warnings.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gsquelart
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8862278 [details] Bug 1355617 - static_cast UNKNOWN_ERROR to status_t to remove harmless warning - https://reviewboard.mozilla.org/r/134214/#review137172
Attachment #8862278 -
Flags: review?(ayang) → review+
Pushed by kwierso@gmail.com: https://hg.mozilla.org/mozilla-central/rev/213097235abe static_cast UNKNOWN_ERROR to status_t to remove harmless warning - r=alfredo
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/213097235abe
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•