1355648 - Add hasOrientation, hasPosition to the Gamepad extension for tracked controllers

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Diego Marcos [:dmarcos]]

This way we can discriminate tracked gamepads consistently since the pose is not always available. It will make the API also consistent with VRDisplay API:

https://w3c.github.io/webvr/spec/1.1/#interface-vrdisplaycapabilities

Comment 1

[Daosheng Mu[:daoshengmu]]

Summarize our discussion:

We will want hasOrientation() and hasPosition() to be true if the sensors for orientation and position are present, even if the device can't get it's tracking position

Should be a three-state logic effectively:


State A - We can't measure our position and will never give you a position

State B - We can measure our position, but don't know our position right now

State C - We can measure our position, and this is the position


hasPosition() should return true for B and C, but false for A

"pose" should never be null, but the position values can be null for A and B. Same thing for orientation..

Comment 2

[Daosheng Mu[:daoshengmu]]

As the spec [1] mentioned, "MUST be null if the gamepad is incapable of providing positional data. When not null, MUST be a three-element array."

[1] https://w3c.github.io/gamepad/extensions.html#gamepadpose-interface

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1355648 - Part 1: Check VR controllers if losing tracking;

Review commit: https://reviewboard.mozilla.org/r/132380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132380/

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1355648 - Part 2: Handle GampadPose losing tracking situation;

Review commit: https://reviewboard.mozilla.org/r/132382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132382/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8860341 [details]
Bug 1355648 - Part 1: Check VR controllers if losing tracking;

https://reviewboard.mozilla.org/r/132380/#review135438

LGTM, Thanks!

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8860342 [details]
Bug 1355648 - Part 2: Handle GampadPose losing tracking situation;

https://reviewboard.mozilla.org/r/132382/#review135440

LGTM

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8860342 [details]
Bug 1355648 - Part 2: Handle GampadPose losing tracking situation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132382/diff/1-2/

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8860342 [details]
Bug 1355648 - Part 2: Handle GampadPose losing tracking situation;

https://reviewboard.mozilla.org/r/132382/#review136364

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f07c7d6ddb8d
Part 1: Check VR controllers if losing tracking; r=kip
https://hg.mozilla.org/integration/autoland/rev/1a675abcc1f0
Part 2: Handle GampadPose losing tracking situation; r=kip,qdot

Comment 10

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/00ef02146b91 for https://treeherder.mozilla.org/logviewer.html#?job_id=94357043&repo=autoland

Comment 11

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1355648 - Part 3: Set position and orientation IsValid properties for GamepadPose tests;

Review commit: https://reviewboard.mozilla.org/r/133772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133772/

Comment 12

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8860341 [details]
Bug 1355648 - Part 1: Check VR controllers if losing tracking;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132380/diff/1-2/

Comment 13

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8860342 [details]
Bug 1355648 - Part 2: Handle GampadPose losing tracking situation;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132382/diff/2-3/

Comment 14

[Daosheng Mu[:daoshengmu]]

In Attachment #8861769 [details], fixing GamepadPose test for GamepadServiceTest and VRServiceTest.

Comment 15

[Daosheng Mu[:daoshengmu]]

Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=548c24650186da0ec5c95e19d587de1921fde296

Comment 16

[:kip (Kearwood Gilbert)]

Comment on attachment 8861769 [details]
Bug 1355648 - Part 3: Set position and orientation IsValid properties for GamepadPose tests;

https://reviewboard.mozilla.org/r/133772/#review137062

LGTM, Thanks!

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9eb118a1ac8
Part 1: Check VR controllers if losing tracking; r=kip
https://hg.mozilla.org/integration/autoland/rev/574ebf5abbfa
Part 2: Handle GampadPose losing tracking situation; r=kip,qdot
https://hg.mozilla.org/integration/autoland/rev/efa1d4ebbc3d
Part 3: Set position and orientation IsValid properties for GamepadPose tests; r=kip

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d9eb118a1ac8
https://hg.mozilla.org/mozilla-central/rev/574ebf5abbfa
https://hg.mozilla.org/mozilla-central/rev/efa1d4ebbc3d

Comment 19

[Chris Mills [:cmills]]

I don't think I need to add anything to the reference docs to cover this - I already documented VRDisplayCapabilities

https://developer.mozilla.org/en-US/docs/Web/API/VRDisplayCapabilities

And I was planning on adding a separate tutorial on how to handle VR controllers in a web app.

Let me know if you think anything else is needed. Thanks!