Closed Bug 1355661 Opened 3 years ago Closed 3 years ago

Add support for brotli streams in jar archives

Categories

(Core :: Networking: JAR, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(2 files)

No description provided.
Whiteboard: [necko-active]
Comment on attachment 8857272 [details]
Bug 1355661 - Add support for brotli streams in Jar archives.

https://reviewboard.mozilla.org/r/129208/#review133930

::: modules/libjar/nsJARInputStream.cpp:294
(Diff revision 1)
>      
>      // make sure we aren't reading too much
>      mZs.avail_out = std::min(aCount, (mOutSize-oldTotalOut));
>      mZs.next_out = (unsigned char*)aBuffer;
>  
> +    if (mMode == MODE_INFLATE) {

Please add an assertion that mMode == MODE_INFLATE when MOZ_JAR_BROTLI is not defined.
Attachment #8857272 - Flags: review?(aklotz) → review+
Comment on attachment 8857271 [details]
Bug 1355661 - Continue inflating even when the Fd was closed, as long as there is still output pending.

https://reviewboard.mozilla.org/r/129206/#review133932
Attachment #8857271 - Flags: review?(aklotz) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/0b3b7652756f
Continue inflating even when the Fd was closed, as long as there is still output pending. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/25dbbe702a74
Add support for brotli streams in Jar archives. r=aklotz
https://hg.mozilla.org/mozilla-central/rev/0b3b7652756f
https://hg.mozilla.org/mozilla-central/rev/25dbbe702a74
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.