Closed
Bug 1355673
Opened 9 years ago
Closed 9 years ago
Don't dump logcat at end of mochitests and reftests in automation
Categories
(Firefox for Android Graveyard :: Testing, enhancement)
Firefox for Android Graveyard
Testing
Tracking
(firefox55 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | affected |
People
(Reporter: gbrown, Assigned: gbrown)
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
It clutters the test log. The logcat artifact provides much more complete information.
(Consider dumping it if a test failed.)
| Assignee | ||
Comment 1•9 years ago
|
||
I think the logcat should be dumped to the test log after a failed run. In the case of a MOZ_CRASH or an assertion count mismatch, the important message is in the logcat, and if that is in the test log, there's a better chance of it being noticed, copied to a bug, and acted upon.
| Assignee | ||
Comment 2•9 years ago
|
||
Just trying to clean up the logs a bit...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b81b511428046a47dc3f8b500f69b6b2a76e9e44
Attachment #8857615 -
Flags: review?(jmaher)
Comment 3•9 years ago
|
||
Comment on attachment 8857615 [details] [diff] [review]
don't dump logcat to test log on success
Review of attachment 8857615 [details] [diff] [review]:
-----------------------------------------------------------------
yay for simpler data!
Attachment #8857615 -
Flags: review?(jmaher) → review+
| Assignee | ||
Comment 4•9 years ago
|
||
Looking at this more closely, I don't see a good way to guarantee that the logcat continues to appear in the test log for cases such as those noted in comment 1. I don't think it's worth spending more time on, so I'm not going to check this in.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•