Closed Bug 1355694 Opened 8 years ago Closed 8 years ago

Intermittent test_quit_restart.py TestQuitRestart.test_in_app_restart | application crashed [@ Checker::StartWriteOp | mozilla::safebrowsing::Classifier::UpdateHashStore]

Categories

(Testing :: Marionette Client and Harness, defect)

Product:
Testing
Component:
Marionette Client and Harness
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: hchang)

References

Details

(Keywords: crash, intermittent-failure)

Crash Data

Same as bug 1355705. Marking as dependent.
status-firefox55: --- → affected
Depends on: 1355705
Or maybe not. The signature is a bit different. Here the first 10 frames from the crashing thread: [task 2017-04-11T20:55:43.882760Z] 20:55:43 INFO - Crash reason: SIGSEGV [task 2017-04-11T20:55:43.883413Z] 20:55:43 INFO - Crash address: 0x0 [task 2017-04-11T20:55:43.884000Z] 20:55:43 INFO - Process uptime: not available [task 2017-04-11T20:55:43.884707Z] 20:55:43 INFO - [task 2017-04-11T20:55:43.885345Z] 20:55:43 INFO - Thread 32 (crashed) [task 2017-04-11T20:55:43.886601Z] 20:55:43 INFO - 0 libxul.so!Checker::StartWriteOp [PLDHashTable.h:474af558075c : 132 + 0x1d] [task 2017-04-11T20:55:43.887253Z] 20:55:43 INFO - eip = 0xf04915ba esp = 0xdbdfaee0 ebp = 0xdbdfaef8 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.887981Z] 20:55:43 INFO - esi = 0xded4a6c4 edi = 0xdbdfaf98 eax = 0x00000000 ecx = 0xf74dc864 [task 2017-04-11T20:55:43.888609Z] 20:55:43 INFO - edx = 0x00000000 efl = 0x00210282 [task 2017-04-11T20:55:43.889257Z] 20:55:43 INFO - Found by: given as instruction pointer in context [task 2017-04-11T20:55:43.889569Z] 20:55:43 INFO - 1 libxul.so!PLDHashTable::Add [PLDHashTable.cpp:474af558075c : 36 + 0x5] [task 2017-04-11T20:55:43.889991Z] 20:55:43 INFO - eip = 0xf0494259 esp = 0xdbdfaf00 ebp = 0xdbdfaf38 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.891411Z] 20:55:43 INFO - esi = 0xded4a6c4 edi = 0xdbdfaf98 [task 2017-04-11T20:55:43.891874Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.892325Z] 20:55:43 INFO - 2 libxul.so!nsBaseHashtable<nsCStringHashKey, long long int, long long int>::Put [nsTHashtable.h:474af558075c : 162 + 0x10] [task 2017-04-11T20:55:43.892773Z] 20:55:43 INFO - eip = 0xf2cfe7fa esp = 0xdbdfaf40 ebp = 0xdbdfaf68 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.893225Z] 20:55:43 INFO - esi = 0xded4a6c4 edi = 0xdbdfaf98 [task 2017-04-11T20:55:43.893666Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.894210Z] 20:55:43 INFO - 3 libxul.so!mozilla::safebrowsing::Classifier::UpdateHashStore [Classifier.cpp:474af558075c : 1302 + 0x15] [task 2017-04-11T20:55:43.894745Z] 20:55:43 INFO - eip = 0xf2de13e2 esp = 0xdbdfaf70 ebp = 0xdbdfb018 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.895325Z] 20:55:43 INFO - esi = 0xf55e11c4 edi = 0x00054cea [task 2017-04-11T20:55:43.895981Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.896644Z] 20:55:43 INFO - 4 libxul.so!mozilla::safebrowsing::Classifier::ApplyUpdatesBackground [Classifier.cpp:474af558075c : 833 + 0xd] [task 2017-04-11T20:55:43.897275Z] 20:55:43 INFO - eip = 0xf2de1942 esp = 0xdbdfb020 ebp = 0xdbdfb098 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.898011Z] 20:55:43 INFO - esi = 0xdbdfb05c edi = 0x00000007 [task 2017-04-11T20:55:43.898656Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.899443Z] 20:55:43 INFO - 5 libxul.so!mozilla::detail::RunnableFunction<mozilla::safebrowsing::Classifier::AsyncApplyUpdates(nsTArray<mozilla::safebrowsing::TableUpdate*>*, mozilla::safebrowsing::Classifier::AsyncUpdateCallback)::<lambda()> >::Run [Classifier.cpp:474af558075c : 752 + 0x11] [task 2017-04-11T20:55:43.900113Z] 20:55:43 INFO - eip = 0xf2de1af7 esp = 0xdbdfb0a0 ebp = 0xdbdfb128 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.900706Z] 20:55:43 INFO - esi = 0xd38a57f0 edi = 0xf55e11c4 [task 2017-04-11T20:55:43.901336Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.901894Z] 20:55:43 INFO - 6 libxul.so!nsThread::ProcessNextEvent [nsThread.cpp:474af558075c : 1269 + 0x9] [task 2017-04-11T20:55:43.902478Z] 20:55:43 INFO - eip = 0xf04e2f40 esp = 0xdbdfb130 ebp = 0xdbdfb1c8 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.903113Z] 20:55:43 INFO - esi = 0xdeb81040 edi = 0xf55a8550 [task 2017-04-11T20:55:43.903684Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.904435Z] 20:55:43 INFO - 7 libxul.so!NS_ProcessNextEvent [nsThreadUtils.cpp:474af558075c : 389 + 0x10] [task 2017-04-11T20:55:43.905031Z] 20:55:43 INFO - eip = 0xf04e520c esp = 0xdbdfb1d0 ebp = 0xdbdfb208 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.905809Z] 20:55:43 INFO - esi = 0xdeb81040 edi = 0xdeddf5c0 [task 2017-04-11T20:55:43.906515Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.907289Z] 20:55:43 INFO - 8 libxul.so!mozilla::ipc::MessagePumpForNonMainThreads::Run [MessagePump.cpp:474af558075c : 368 + 0xc] [task 2017-04-11T20:55:43.907850Z] 20:55:43 INFO - eip = 0xf08a728c esp = 0xdbdfb210 ebp = 0xdbdfb258 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.908339Z] 20:55:43 INFO - esi = 0xdeb904f0 edi = 0xdeddf5c0 [task 2017-04-11T20:55:43.908843Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.909423Z] 20:55:43 INFO - 9 libxul.so!MessageLoop::RunInternal [message_loop.cc:474af558075c : 238 + 0x14] [task 2017-04-11T20:55:43.910015Z] 20:55:43 INFO - eip = 0xf087620e esp = 0xdbdfb260 ebp = 0xdbdfb288 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.910507Z] 20:55:43 INFO - esi = 0xdeddf5c0 edi = 0x00000000 [task 2017-04-11T20:55:43.911016Z] 20:55:43 INFO - Found by: call frame info [task 2017-04-11T20:55:43.911508Z] 20:55:43 INFO - 10 libxul.so!MessageLoop::Run [message_loop.cc:474af558075c : 231 + 0x7] [task 2017-04-11T20:55:43.912079Z] 20:55:43 INFO - eip = 0xf0876233 esp = 0xdbdfb290 ebp = 0xdbdfb2b8 ebx = 0xf55a3d78 [task 2017-04-11T20:55:43.912505Z] 20:55:43 INFO - esi = 0xdeddf5c0 edi = 0x00000000 [task 2017-04-11T20:55:43.912927Z] 20:55:43 INFO - Found by: call frame info Henry, what do you think?
Flags: needinfo?(hchang)
Summary: Intermittent test_quit_restart.py TestQuitRestart.test_in_app_restart | application crashed [@ Checker::StartWriteOp] → Intermittent test_quit_restart.py TestQuitRestart.test_in_app_restart | application crashed [@ Checker::StartWriteOp | mozilla::safebrowsing::Classifier::UpdateHashStore]
I would think they were caused by the same root cause: the non-thread-safe object access on different threads concurrently. http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/toolkit/components/url-classifier/Classifier.cpp#1302 BTW, I have landed Bug 1354968 so this one is expected to be fixed as well :)
Flags: needinfo?(hchang)
Depends on: 1354968
No longer depends on: 1355705
Status: NEW → RESOLVED
Closed: 8 years ago
Keywords: bulk-close-intermittents
Resolution: --- → INCOMPLETE
This got actually fixed by the patch on bug 1354968 for Firefox 55.
Assignee: nobody → hchang
status-firefox55: affected → fixed
Resolution: INCOMPLETE → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Remote Protocol
Moving bug to Testing::Marionette Client and Harness component per bug 1815831.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in before you can comment on or make changes to this bug.