Closed Bug 1355702 Opened 6 years ago Closed 6 years ago

Reduce WrImageKey allocation for ExternalImages on sync ImageContainer

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 2 obsolete files)

patch - Reduce WrImageKey allocation for ExternalImages on sync ImageContainer
11.96 KB, patch
nical
: review+
Details | Diff | Splinter Review 
WrImageKey is allocated and deallocated very often. It seems better to reduce the allocation/deallocation.
Assignee: nobody → sotaro.ikeda.g
Blocks: webrender
Depends on: 1355678
Depends on: 1355720
Depends on: 1355743
Andrew's been looking at this.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> Andrew's been looking at this.

:aosmond, is there a bug for it?
Flags: needinfo?(aosmond)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> Andrew's been looking at this.

:jrmuizel, is it Bug 1331944>
Flags: needinfo?(jmuizelaar)
(In reply to Sotaro Ikeda [:sotaro] from comment #3)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> > Andrew's been looking at this.
> 
> :jrmuizel, is it Bug 1331944>

Correction:
  :jrmuizel, is it Bug 1331944?
Yeah, that's probably where the work will happen. I looked at those patches more today and then don't include keeping the key around but Andrew doesn't think it will be too hard to add.
Flags: needinfo?(jmuizelaar)
Depends on: 1356088
Flags: needinfo?(aosmond)
I checked Bug 1331944, it seems a bit orthogonal, since this bug focuses only on ExternalImages on sync ImageContainer.
Summary: Reduce WrImageKey allocation → Reduce WrImageKey allocation for ExternalImages on sync ImageContainer
Depends on: 1356130
rebased.
Attachment #8859043 - Attachment is obsolete: true
Depends on: 1357338
Attachment #8859083 - Flags: review?(nical.bugzilla)
Attachment #8859083 - Flags: review?(nical.bugzilla) → review+
See Also: → 1331944
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/9c846a716941
Reduce WrImageKey allocation for ExternalImages on sync ImageContainer
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.