Disable and remove layout panel promotion code in release 58

RESOLVED FIXED in Firefox 58

Status

()

Firefox
Developer Tools: Inspector
P3
enhancement
RESOLVED FIXED
a year ago
6 months ago

People

(Reporter: jdescottes, Assigned: gl)

Tracking

unspecified
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The layout panel promotion should only last for a certain period (one release max?)

After that we should remove the code that was added by Bug 1348004.
Gabriel, 57 is ready to ride the trains soon, should we remove the code now so that the "new" message only appears during release 56 and then goes away in 57?
Flags: needinfo?(gl)
(Assignee)

Comment 2

8 months ago
(In reply to Patrick Brosset <:pbro> from comment #1)
> Gabriel, 57 is ready to ride the trains soon, should we remove the code now
> so that the "new" message only appears during release 56 and then goes away
> in 57?

I had a chat with clarkbw about this and he thought with 57 a lot of new people will also be coming back to devtools for the first time. So, it didn't hurt to to keep the promo until after 57.
Flags: needinfo?(gl)

Updated

8 months ago
Summary: Disable and remove layout panel promotion code after release 56 → Disable and remove layout panel promotion code in release 58
(Assignee)

Updated

6 months ago
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Reporter)

Comment 4

6 months ago
mozreview-review
Comment on attachment 8918144 [details]
Bug 1355747 - Disable and remove layout panel promotion code in release 58.

https://reviewboard.mozilla.org/r/189006/#review194364

Thanks! R+ with a green try and two small issues to fix before landing.

::: devtools/client/inspector/layout/layout.js:87
(Diff revision 1)
>  
>      let provider = createElement(Provider, {
>        id: "layoutview",
>        key: "layoutview",
>        store: this.store,
> -      title: INSPECTOR_L10N.getStr("inspector.sidebar.layoutViewTitle2"),
> +      title: INSPECTOR_L10N.getStr("inspector.sidebar.layoutViewTitle2")

nit: keep the comma-last

::: devtools/client/preferences/devtools.js
(Diff revision 1)
> -// Counter to promote the inspector layout view.
> -// @remove after release 56 (See Bug 1355747)
> -pref("devtools.promote.layoutview", 1);
> -// Whether or not to show the promote bar in the layout view
> -// @remove after release 56 (See Bug 1355747)
> -pref("devtools.promote.layoutview.showPromoteBar", true);

We should also remove the references to devtools.promote.layoutview.showPromoteBar in devtools/client/inspector/grids/test/head.js
Attachment #8918144 - Flags: review?(jdescottes) → review+

Comment 5

6 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/508179b0dad5
Disable and remove layout panel promotion code in release 58. r=jdescottes
Backed out for linting failure at devtools/client/inspector/layout/layout.js:7: 'Services' is assigned a value but never used:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c297947982b5766e3e3c762f625717bfd2412b

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=508179b0dad5311979a135b9a03721da53ca868b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136823889&repo=mozilla-inbound

> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/inspector/layout/layout.js:7:7 | 'Services' is assigned a value but never used. (no-unused-vars)
Flags: needinfo?(gl)

Comment 7

6 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a25dd5df93da
Disable and remove layout panel promotion code in release 58. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/a25dd5df93da
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Assignee)

Updated

6 months ago
Flags: needinfo?(gl)
You need to log in before you can comment on or make changes to this bug.