1355747 - Disable and remove layout panel promotion code in release 58

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

The layout panel promotion should only last for a certain period (one release max?)

After that we should remove the code that was added by Bug 1348004.

Comment 1

[Patrick Brosset <:pbro>]

Gabriel, 57 is ready to ride the trains soon, should we remove the code now so that the "new" message only appears during release 56 and then goes away in 57?

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Patrick Brosset <:pbro> from comment #1)
> Gabriel, 57 is ready to ride the trains soon, should we remove the code now
> so that the "new" message only appears during release 56 and then goes away
> in 57?

I had a chat with clarkbw about this and he thought with 57 a lot of new people will also be coming back to devtools for the first time. So, it didn't hurt to to keep the promo until after 57.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1355747 - Disable and remove layout panel promotion code in release 58.

Review commit: https://reviewboard.mozilla.org/r/189006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/189006/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8918144 [details]
Bug 1355747 - Disable and remove layout panel promotion code in release 58.

https://reviewboard.mozilla.org/r/189006/#review194364

Thanks! R+ with a green try and two small issues to fix before landing.

::: devtools/client/inspector/layout/layout.js:87
(Diff revision 1)
>  
>      let provider = createElement(Provider, {
>        id: "layoutview",
>        key: "layoutview",
>        store: this.store,
> -      title: INSPECTOR_L10N.getStr("inspector.sidebar.layoutViewTitle2"),
> +      title: INSPECTOR_L10N.getStr("inspector.sidebar.layoutViewTitle2")

nit: keep the comma-last

::: devtools/client/preferences/devtools.js
(Diff revision 1)
> -// Counter to promote the inspector layout view.
> -// @remove after release 56 (See Bug 1355747)
> -pref("devtools.promote.layoutview", 1);
> -// Whether or not to show the promote bar in the layout view
> -// @remove after release 56 (See Bug 1355747)
> -pref("devtools.promote.layoutview.showPromoteBar", true);

We should also remove the references to devtools.promote.layoutview.showPromoteBar in devtools/client/inspector/grids/test/head.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/508179b0dad5
Disable and remove layout panel promotion code in release 58. r=jdescottes

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for linting failure at devtools/client/inspector/layout/layout.js:7: 'Services' is assigned a value but never used:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c297947982b5766e3e3c762f625717bfd2412b

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=508179b0dad5311979a135b9a03721da53ca868b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136823889&repo=mozilla-inbound

> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/client/inspector/layout/layout.js:7:7 | 'Services' is assigned a value but never used. (no-unused-vars)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a25dd5df93da
Disable and remove layout panel promotion code in release 58. r=jdescottes

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a25dd5df93da