Closed Bug 1355752 Opened 3 years ago Closed 3 years ago

Remove B2G code from layout modules

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bmo, Assigned: bmo)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

This bug aims to remove all B2G relevant code from layout modules.
Assignee: nobody → aschen
Blocks: nukeb2g
Status: NEW → ASSIGNED
Attachment #8857948 - Flags: review?(tlin)
Attachment #8857949 - Flags: review?(jmuizelaar)
Attachment #8857950 - Flags: review?(mconley)
Attachment #8857952 - Flags: review?(dholbert)
Attachment #8857953 - Flags: review?(bugmail)
Attachment #8857954 - Flags: review?(mstange)
Comment on attachment 8857949 [details]
Bug 1355752 - Remove B2G code from PresShell files.

https://reviewboard.mozilla.org/r/129978/#review132552

::: layout/base/PresShell.cpp:6424
(Diff revision 1)
>  
>    nsAutoNotifyDidPaint notifyDidPaint(this, aFlags);
>  
> -  // Whether or not we should set first paint when painting is
> -  // suppressed is debatable. For now we'll do it because
> -  // B2G relies on first paint to configure the viewport and
> +  // Whether or not we should set first paint when painting is suppressed
> +  // is debatable. For now we'll do it and we only want to do that when
> +  // we have real content to paint. See Bug 798245

I think this comment is probably better left intact. You can change the tense though. i.e. 'B2G relied' The new version makes less sense to me and misses the original intention that the author had.
Attachment #8857949 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8857953 [details]
Bug 1355752 - Remove B2G code from nsGfxScrollFrame.cpp.

https://reviewboard.mozilla.org/r/129986/#review132556
Attachment #8857953 - Flags: review?(bugmail) → review+
Attachment #8857951 - Flags: review?(jmaher)
Comment on attachment 8857951 [details]
Bug 1355752 - Remove B2G code from layout/build files.

https://reviewboard.mozilla.org/r/129982/#review132560

lgtm- thanks for cleaning this up
Attachment #8857951 - Flags: review?(jmaher) → review+
See Also: → 1306555
Comment on attachment 8857952 [details]
Bug 1355752 - Remove B2G code from nsFormControlFrame.cpp & forms.css.

https://reviewboard.mozilla.org/r/129984/#review132632

r=me
Attachment #8857952 - Flags: review?(dholbert) → review+
Comment on attachment 8857950 [details]
Bug 1355752 - Remove B2G code from nsCSSFrameConstructor.cpp.

https://reviewboard.mozilla.org/r/129980/#review132656

Hey aschen, seems straight-forward and okay - but I suspect you're going to want a layout peer to review this. I'm pretty unfamiliar with this code.
Attachment #8857950 - Flags: review?(mconley)
Comment on attachment 8857950 [details]
Bug 1355752 - Remove B2G code from nsCSSFrameConstructor.cpp.

https://reviewboard.mozilla.org/r/129980/#review132658

I'll r+ this one.
Attachment #8857950 - Flags: review+
Comment on attachment 8857949 [details]
Bug 1355752 - Remove B2G code from PresShell files.

https://reviewboard.mozilla.org/r/129978/#review132552

> I think this comment is probably better left intact. You can change the tense though. i.e. 'B2G relied' The new version makes less sense to me and misses the original intention that the author had.

Thanks for review. Updated as suggestion.
Attachment #8857950 - Flags: review?(mconley) → review+
Comment on attachment 8857954 [details]
Bug 1355752 - Remove B2G code from FrameLayerBuilder.cpp.

https://reviewboard.mozilla.org/r/129988/#review132758
Attachment #8857954 - Flags: review?(mstange) → review+
Comment on attachment 8857948 [details]
Bug 1355752 - Remove B2G wording in AccessibleCaret.

https://reviewboard.mozilla.org/r/129976/#review132756

r=me. Thanks for the patch.
Attachment #8857948 - Flags: review?(tlin) → review+
Since this bug is close to landing, with one r? left, let me ask the question that was asked in bug 1306555 comment 2 but never received an answer (the quick un-ni? surely didn't help):

   Jet, can we remove widget/gonk/ and all #ifdef MOZ_WIDGET_GONK code from the repo now?
   Can you escalate if you don't know?  Thanks.

[Please note that while this bug says "Remove B2G", it's actually removing gonk code, not b2g code, which is a distinction people have made in the past, while advocating for keeping gonk support]
Flags: needinfo?(bugs)
(In reply to Mike Hommey [:glandium] (VAC: Apr 20-May 4) from comment #24)
> Since this bug is close to landing, with one r? left, let me ask the
> question that was asked in bug 1306555 comment 2 but never received an
> answer (the quick un-ni? surely didn't help):
> 
>    Jet, can we remove widget/gonk/ and all #ifdef MOZ_WIDGET_GONK code from
> the repo now?
>    Can you escalate if you don't know?  Thanks.
> 
> [Please note that while this bug says "Remove B2G", it's actually removing
> gonk code, not b2g code, which is a distinction people have made in the
> past, while advocating for keeping gonk support]

Gecko no longer builds with #define MOZ_WIDGET_GONK. Given that bug 1245091 is now marked WONTFIX, we should remove these #ifdef's. I understand the distinction between B2G and GONK, and honestly wish we could keep Gecko building on top of the Android bare metal API's, but that wish doesn't match reality.
Flags: needinfo?(bugs)
I take it we can now be more aggressive about removing gonk directories... I will file a new bug for the directories not covered by existing bugs.
Comment on attachment 8857949 [details]
Bug 1355752 - Remove B2G code from PresShell files.

https://reviewboard.mozilla.org/r/129978/#review133966
Attachment #8857949 - Flags: review?(jmuizelaar) → review+
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c018f36dcdad
Remove B2G wording in AccessibleCaret. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/e42cf4911d08
Remove B2G code from PresShell files. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/1eb9604b76a9
Remove B2G code from nsCSSFrameConstructor.cpp. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/bc04a783948e
Remove B2G code from layout/build files. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/16028292e2f1
Remove B2G code from nsFormControlFrame.cpp & forms.css. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/a1c51bf7ec8a
Remove B2G code from nsGfxScrollFrame.cpp. r=kats
https://hg.mozilla.org/integration/autoland/rev/7d77113f3841
Remove B2G code from FrameLayerBuilder.cpp. r=mstange
(In reply to (VAC until May 4) Mike Hommey [:glandium] from comment #26)
> I take it we can now be more aggressive about removing gonk directories... I
> will file a new bug for the directories not covered by existing bugs.

Keep tree clean looks good to me. Thanks for the help.
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.