1355755 - Cleanup hardcoded colors defined in tabs.css

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Discussed during the review of Bug 1348004:

> ::: devtools/client/shared/components/tabs/tabs.css:28
> (Diff revision 3)
> > +  position: relative;
> >  }
> >  
> >  .tabs .tabs-menu-item a {
> > -  display: block;
> > +  display: flex;
> >    color: #A9A9A9;
> 
> Unrelated to your patch, but why don't we have a theme variable for this. If 
> this is the color of the text inside tabs, it should really be a theme variable, 
> and I'm pretty sure we have one close to that already.
>

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1355755 - cleanup hardcoded colors in tabs.css;

Review commit: https://reviewboard.mozilla.org/r/129380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129380/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8857387 [details]
Bug 1355755 - cleanup hardcoded colors in tabs.css;

https://reviewboard.mozilla.org/r/129380/#review131962

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6ff20e03b5e
cleanup hardcoded colors in tabs.css;r=pbro

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a6ff20e03b5e