1355763 - Clarify opaque vs premult-alpha vs non-premult-alpha

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Description

[Kelsey Gilbert [:jgilbert]]

This should make it more clear when we can skip conversion, which is particularly useful for faster video uploads. (or at least making the fast-path broader, easier to hit)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1355763 - Add gfxAlphaType for specifying opaque/premult/non-premult. -

Review commit: https://reviewboard.mozilla.org/r/129396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129396/

Comment 2

[Kelsey Gilbert [:jgilbert]]

This patch makes at least the webm here work:
http://alteredqualia.com/xg/examples/webgl_video_aspect_ratio.html

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1355763 - Handle UNPACK_ state for ConvertPlanarYCbCr, and reject blits with _SKIP_* for now. -

Review commit: https://reviewboard.mozilla.org/r/129508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129508/

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8857402 [details]
Bug 1355763 - Add gfxAlphaType for specifying opaque/premult/non-premult. -

https://reviewboard.mozilla.org/r/129396/#review132020

r=me after fixing some nits.

::: dom/canvas/CanvasRenderingContext2D.h:412
(Diff revision 1)
>        CurrentState().imageSmoothingEnabled = aImageSmoothingEnabled;
>      }
>    }
>  
>    void DrawWindow(nsGlobalWindow& aWindow, double aX, double aY,
> -                  double aW, double aH,
> +      double aW, double aH,

This indentation seems to be wrong.

::: testing/talos/talos/test.py:428
(Diff revision 1)
> +    gecko_profile_interval = 10
> +    gecko_profile_entries = 2000000
> +    win_counters = w7_counters = linux_counters = mac_counters = None
> +    """ ASAP mode """
> +    filters = filter.ignore_first.prepare(1) + filter.median.prepare()
> +    unit = 'ms'

Please remove this unused code.

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8857539 [details]
Bug 1355763 - Handle UNPACK_ state for ConvertPlanarYCbCr, and reject blits with _SKIP_* for now. -

https://reviewboard.mozilla.org/r/129508/#review132314

LGTM

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857402 [details]
Bug 1355763 - Add gfxAlphaType for specifying opaque/premult/non-premult. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129396/diff/1-2/

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857539 [details]
Bug 1355763 - Handle UNPACK_ state for ConvertPlanarYCbCr, and reject blits with _SKIP_* for now. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129508/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f97fd860c168
Add gfxAlphaType for specifying opaque/premult/non-premult. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/f71e84602f68
Handle UNPACK_ state for ConvertPlanarYCbCr, and reject blits with _SKIP_* for now. - r=daoshengmu

Comment 9

[Iris Hsiao [:ihsiao]]

backed out for assertion failure at ImageBitmap.cpp like https://treeherder.mozilla.org/logviewer.html#?job_id=91189015&repo=mozilla-inbound&lineNumber=32241

https://hg.mozilla.org/integration/mozilla-inbound/rev/d71858e17d35
https://hg.mozilla.org/integration/mozilla-inbound/rev/27c85d8a0ce5

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1355763 - Only premult if there's something to premult.

Review commit: https://reviewboard.mozilla.org/r/130044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130044/

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857402 [details]
Bug 1355763 - Add gfxAlphaType for specifying opaque/premult/non-premult. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129396/diff/2-3/

Comment 12

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8857539 [details]
Bug 1355763 - Handle UNPACK_ state for ConvertPlanarYCbCr, and reject blits with _SKIP_* for now. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129508/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0e8fd36b730
Add gfxAlphaType for specifying opaque/premult/non-premult. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbd23665a2d1
Handle UNPACK_ state for ConvertPlanarYCbCr, and reject blits with _SKIP_* for now. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9683ac4e2d1
Only premult if there's something to premult.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f0e8fd36b730
https://hg.mozilla.org/mozilla-central/rev/bbd23665a2d1
https://hg.mozilla.org/mozilla-central/rev/c9683ac4e2d1