Closed Bug 1355765 Opened 3 years ago Closed 2 years ago

[PATCH] branches is misspelled in the summary of js/src/tests/js1_7/extensions/regress-346773.js

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: shlomif, Assigned: shlomif)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170329154614

Steps to reproduce:

I searched the code for misspellings.


Actual results:

I found the line:

var summary = 'Do not crash compiling with misplaced brances in function';



Expected results:

It should read "branches" instead of "brances".
Component: Untriaged → General
Product: Firefox → Core
Attachment #8857410 - Flags: review?(luke)
Attachment #8857410 - Flags: review?(luke) → review+
Hi! Can this be applied, please? Ping.
Keywords: checkin-needed
Hi! The patch returns the following error when trying to apply:

hg qpush -a
(working directory not at a head)
applying firefox-branches-misspelling-v0.1.0.patch
unable to find 'js/src/tests/js1_7/extensions/regress-346773.js' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file js/src/tests/js1_7/extensions/regress-346773.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh firefox-branches-misspelling-v0.1.0.patch

Please take a look. Thanks!
Flags: needinfo?(shlomif)
The file was moved inside the repository - here is the new patch - please apply.
Attachment #8857410 - Attachment is obsolete: true
Flags: needinfo?(shlomif)
I think this needs to be reviewed once again before we can apply it. Could :luke please take a look over it and see if it's ok? Thank you.
Flags: needinfo?(luke)
Comment on attachment 8938713 [details] [diff] [review]
firefox-branches-misspelling-v0.1.1.patch

Review of attachment 8938713 [details] [diff] [review]:
-----------------------------------------------------------------

Sure this is fine, thanks for the patch!
Attachment #8938713 - Flags: review+
Flags: needinfo?(luke)
Keywords: leave-open
Er wrong keyword.
Component: General → JavaScript Engine
Assignee: nobody → shlomif
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcd25d63842
Fix the misspelling of branches in regress-346773.js. r=jandem
Keywords: checkin-needed
(In reply to Pulsebot from comment #7)
> Pushed by ryanvm@gmail.com:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcd25d63842
> Fix the misspelling of branches in regress-346773.js. r=jandem

great, thanks Ryan!
https://hg.mozilla.org/mozilla-central/rev/dbcd25d63842
Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Thanks for applying the patch.
You need to log in before you can comment on or make changes to this bug.