Closed Bug 1355765 Opened 4 years ago Closed 3 years ago
[PATCH] branches is misspelled in the summary of js/src/tests/js1
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20170329154614 Steps to reproduce: I searched the code for misspellings. Actual results: I found the line: var summary = 'Do not crash compiling with misplaced brances in function'; Expected results: It should read "branches" instead of "brances".
Hi! Can this be applied, please? Ping.
Hi! The patch returns the following error when trying to apply: hg qpush -a (working directory not at a head) applying firefox-branches-misspelling-v0.1.0.patch unable to find 'js/src/tests/js1_7/extensions/regress-346773.js' for patching (use '--prefix' to apply patch relative to the current directory) 1 out of 1 hunks FAILED -- saving rejects to file js/src/tests/js1_7/extensions/regress-346773.js.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh firefox-branches-misspelling-v0.1.0.patch Please take a look. Thanks!
The file was moved inside the repository - here is the new patch - please apply.
Attachment #8857410 - Attachment is obsolete: true
I think this needs to be reviewed once again before we can apply it. Could :luke please take a look over it and see if it's ok? Thank you.
Comment on attachment 8938713 [details] [diff] [review] firefox-branches-misspelling-v0.1.1.patch Review of attachment 8938713 [details] [diff] [review]: ----------------------------------------------------------------- Sure this is fine, thanks for the patch!
Attachment #8938713 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcd25d63842 Fix the misspelling of branches in regress-346773.js. r=jandem
(In reply to Pulsebot from comment #7) > Pushed by firstname.lastname@example.org: > https://hg.mozilla.org/integration/mozilla-inbound/rev/dbcd25d63842 > Fix the misspelling of branches in regress-346773.js. r=jandem great, thanks Ryan!
Thanks for applying the patch.
You need to log in before you can comment on or make changes to this bug.