1355778 - Harmonise the ESLint configuration for eslint-plugin-mozilla/spidermonkey-js with the Mozilla recommended one

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

It gets slightly annoying that there's a few differences between the Mozilla recommended ESLint config, and the one we currently use for our eslint-plugin-*.

Hence, I'd like to unify them a bit and reduce the duplicate rules.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1355778 - Unify some of the eslint-plugin-* rules to match the Mozilla recommended configuration.

Review commit: https://reviewboard.mozilla.org/r/129428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129428/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1355778 - Autofix ESLint issues in eslint-plugin-* due to the rule changes.

Review commit: https://reviewboard.mozilla.org/r/129430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129430/

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1355778 - Manual fix of ESLint issues in eslint-plugin-* due to the rule changes.

Review commit: https://reviewboard.mozilla.org/r/129432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129432/

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8857432 [details]
Bug 1355778 - Autofix ESLint issues in eslint-plugin-* due to the rule changes.

https://reviewboard.mozilla.org/r/129430/#review132124

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8857433 [details]
Bug 1355778 - Manual fix of ESLint issues in eslint-plugin-* due to the rule changes.

https://reviewboard.mozilla.org/r/129432/#review132128

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8857431 [details]
Bug 1355778 - Unify some of the eslint-plugin-* rules to match the Mozilla recommended configuration.

https://reviewboard.mozilla.org/r/129428/#review132130

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0baa1e8edbd7
Unify some of the eslint-plugin-* rules to match the Mozilla recommended configuration. r=mossop
https://hg.mozilla.org/integration/autoland/rev/3898b0c456d6
Autofix ESLint issues in eslint-plugin-* due to the rule changes. r=mossop
https://hg.mozilla.org/integration/autoland/rev/cf2b51a98a3f
Manual fix of ESLint issues in eslint-plugin-* due to the rule changes. r=mossop

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0baa1e8edbd7
https://hg.mozilla.org/mozilla-central/rev/3898b0c456d6
https://hg.mozilla.org/mozilla-central/rev/cf2b51a98a3f