1355804 - Hebrew locale doesn't load correctly when language set to default system language

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Tomer Cohen :tomer]

Attachment: Screenshot

Steps to reproduce:
a. Set Android language to Hebrew
b. Set Firefox locale to Default
c. Make sure to stop the Fennec process and start it again

Current result:
Some menus appear in Hebrew, while others appear as English. For example, the main menu is in Hebrew, while the context menu when tapping and holding over a link kept in English. The about: page kept in English, while Settings are in Hebrew. 

Expected result:
When setting the browser locale to Hebrew manually, everything works as expected.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks for reporting :tomer!

I believe it's a dupe of bug 1351873. The patch to fix it just landed in bug 1354055, so it should be fixed in a day or two.

Let me know if it won't be fixed for you!

Comment 2

[Itiel]

I just tested and this issue is reproducible on 53beta1 which was released over a month ago, so I don't think this is related to bug 1354055.

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

let's reopen then. It doesn't seem to be related to the cause of the regression in 55, but still may be fixed with bug 1354055 landing.

Comment 4

[Tomer Cohen :tomer]

Amir Aharoni reporting that he was unable to reproduce this bug on Galaxy S7/Android 7 using a recent nightly.

Comment 5

[Tomer Cohen :tomer]

I am unable to reproduce it as well on 2017-04-17 nightly. Maybe bug 1351873 solved it after all...

Comment 6

[Itiel]

(In reply to Tomer Cohen :tomer from comment #5)
> I am unable to reproduce it as well on 2017-04-17 nightly. Maybe bug 1351873
> solved it after all...

Nope, unfortunately this is still an issue on my device (Samsung Galaxy S5 G900F Android 6.0.1) also after cleaning Date Nightly's app data, on the same 2017-04-17 build.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

ItielMan, can you share:

 - You Android OS locale
 - You Fennec locale selected in preferences
 - The locale your Preferences are in
 - The locale your, say, Addons page is in

If you can plug in WebIDE to your Android can you show me result of:

 - Services.locale.getRequestedLocales();
 - Services.locale.getAppLocalesAsLangTags();
 - Components.classes["@mozilla.org/intl/ospreferences;1"].
             getService(Components.interfaces.mozIOSPreferences).GetSystemLocales();

Thanks!

Comment 8

[Itiel]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #7)
> ItielMan, can you share:
> 
>  - You Android OS locale
>  - You Fennec locale selected in preferences
>  - The locale your Preferences are in
>  - The locale your, say, Addons page is in
> 
> If you can plug in WebIDE to your Android can you show me result of:
> 
>  - Services.locale.getRequestedLocales();
>  - Services.locale.getAppLocalesAsLangTags();
>  - Components.classes["@mozilla.org/intl/ospreferences;1"].
>             
> getService(Components.interfaces.mozIOSPreferences).GetSystemLocales();
> 
> Thanks!

1. Hebrew
2. "Default". Selecting "Hebrew" manually fixes the issue.
3. Hebrew.
4. English.

5. Array [ "en-US" ]
6. Array [ "en-US", "en-ZA", "en-GB" ]
7. nsJSCID { name: "@mozilla.org/intl/ospreferences;1", number: "{65944815-e9ae-48bd-a2bf-f110872095…", valid: true }
8. ReferenceError: getService is not defined

And if 7 and 8 should be combined:
TypeError: Components.classes['@mozilla.org/intl/ospreferences;1'].getService(...).GetSystemLocales is not a function

Comment 9

[Tomer Cohen :tomer]

(In reply to ItielMaN from comment #8)

> Components.classes['@mozilla.org/intl/ospreferences;1'].getService(...).
> GetSystemLocales is not a function
Try 
  Components.classes["@mozilla.org/intl/ospreferences;1"].getService(Components.interfaces.mozIOSPreferences).getSystemLocales();

Comment 10

[Itiel]

(In reply to Tomer Cohen :tomer from comment #9)
> (In reply to ItielMaN from comment #8)
> 
> > Components.classes['@mozilla.org/intl/ospreferences;1'].getService(...).
> > GetSystemLocales is not a function
> Try 
>  
> Components.classes["@mozilla.org/intl/ospreferences;1"].
> getService(Components.interfaces.mozIOSPreferences).getSystemLocales();

Array [ "en-US" ]

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Oh, yeah, sorry. 7/8 should be combined and I guess it's `getSystemLocales` not `GetSystemLocales`.

wrt. the bug - I'm not sure how selecting "Hebrew" can fix the issue since you don't have hebrew locales according to (6).

What do you mean by "fixing"? Your Addons page is in Hebrew?

> Array [ "en-US" ]

So the API returns en-US, but your OS is really in Hebrew? That's very confusing.

I see two question marks in your results:

1) How can your Addons page be in Hebrew if Services.locale.getAvailableLocales does not return Hebrew which means there is no Hebrew locale available.
2) Why your OSPreferences::GetSystemLocales returns en-US if your Android OS locale is not en-US?

Can you also tell me what is the value of the "intl.locale.os" preference?

Comment 12

[Tomer Cohen :tomer]

WFM on Galaxy S4/Cyanogen: 

> Services.locale.getRequestedLocales();
Array [ "he-IL" ]
> Services.locale.getAppLocalesAsLangTags();
Array [ "he", "en-US" ]
> Components.classes["@mozilla.org/intl/ospreferences;1"].getService(Components.interfaces.mozIOSPreferences).getSystemLocales();
Array [ "he-IL" ]

Comment 13

[Itiel]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #11)
> Oh, yeah, sorry. 7/8 should be combined and I guess it's `getSystemLocales`
> not `GetSystemLocales`.
> 
> wrt. the bug - I'm not sure how selecting "Hebrew" can fix the issue since
> you don't have hebrew locales according to (6).
> 
> What do you mean by "fixing"? Your Addons page is in Hebrew?
> 
> > Array [ "en-US" ]
> 
> So the API returns en-US, but your OS is really in Hebrew? That's very
> confusing.
> 
> I see two question marks in your results:
> 
> 1) How can your Addons page be in Hebrew if
> Services.locale.getAvailableLocales does not return Hebrew which means there
> is no Hebrew locale available.
> 2) Why your OSPreferences::GetSystemLocales returns en-US if your Android OS
> locale is not en-US?
> 
> Can you also tell me what is the value of the "intl.locale.os" preference?

> What do you mean by "fixing"? Your Addons page is in Hebrew?

Yes (same for about:firefox), though right clicking URLs context menu is still in English.

> 1) How can your Addons page be in Hebrew if
> Services.locale.getAvailableLocales does not return Hebrew which means there
> is no Hebrew locale available.

Sorry about that! I mistook #3 (saying that Addons page is in Hebrew), I had the Nightly locale set to "Hebrew" at that time :)
When set to default, the Addons page is in English.

> 2) Why your OSPreferences::GetSystemLocales returns en-US if your Android OS
> locale is not en-US?

That is beyond me :)

> Can you also tell me what is the value of the "intl.locale.os" preference?

he-IL

Comment 14

[Itiel]

Upon running Nightly I see in the console:
> Locale:OS: he-IL
> New OS locale.
> Default intl.accept_languages = en-US, en
> Setting intl.accept_languages to en-us,he-il,en

Comment 15

[Itiel]

Not sure how, but clean-installing Nightly fixed it.
When Nightly's locale set to Default, the Hebrew translations are now loaded everywhere.

Closing as RESOLVED FIXED.

Comment 16

[Kevin Brosnan [Ex-Mozilla]]

works for me is used for bugs that resolved themselves without a code change

Comment 17

[Tomer Cohen :tomer]

(In reply to Kevin Brosnan [:kbrosnan] from comment #16)
> works for me is used for bugs that resolved themselves without a code change

Reopening, since we are not fully understand what causing it, and would like to discuss if it is possible to uplift the fix (bug 1351873?).

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

I don't believe it's viable for uplift, sorry, too many changes between 54 and 55 in between.

Comment 19

[Zibi Braniecki [:zbraniecki][:gandalf]]

Marking as fixed