Closed Bug 1355836 Opened 7 years ago Closed 4 years ago

Fix and re-enable layout/base/tests/test_event_target_radius.html on Android

Categories

(Core :: Panning and Zooming, defect, P2)

Product:
Core
Component:
Panning and Zooming
Platform:
Unspecified
Android
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: RyanVM, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(3 files)

Bug 1355836 - Improve logging in PositionedEventTargeting slightly. r?snorp
47 bytes, text/x-phabricator-request
Details | Review
Bug 1355836 - Ensure the event retargeting tests pass on Android. r?snorp
47 bytes, text/x-phabricator-request
Details | Review
Bug 1355836 - Re-enable event retargeting tests on Android. r?snorp
47 bytes, text/x-phabricator-request
Details | Review 
As part of getting layout/base/tests running on Android again, it was determined that test_event_target_radius.html is currently permafailing. In the interests of getting the directory running again, the test has been disabled for now until it can be fixed and re-enabled. The failures look pretty similar to bug 1349169 as well, for whatever that's worth.

Also, from bug 1355206:
(In reply to Daniel Holbert [:dholbert] from bug 1355206 comment #1)
>  (B) We probably want to convert the B2G special cases (in
> test_event_target_radius.html in particular) to be an Android special-case
> instead.

I tried playing around with that special casing more, and while I'm pretty sure I got the right magic to replace the B2G check with one for Android, the failures still continued. If I removed all special casing, I got test timeouts.

369 INFO TEST-START | layout/base/tests/test_event_target_radius.html
370 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | WARNING: mm 6.2833404541015625 too small in this configuration. Test results will be bogus
371 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_event_target_radius.html | checking 't' offset 181.6834259033203,10  - got "t", expected "body"
    SimpleTest.is@SimpleTest/SimpleTest.js:310:5
    testMouseClick@layout/base/tests/test_event_target_radius.html:93:5
    runTest@layout/base/tests/test_event_target_radius.html:122:3
372 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't' offset 169.1167449951172,10 
373 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_event_target_radius.html | checking 't' offset 10,136.55006408691406  - got "t", expected "body"
    SimpleTest.is@SimpleTest/SimpleTest.js:310:5
    testMouseClick@layout/base/tests/test_event_target_radius.html:93:5
    runTest@layout/base/tests/test_event_target_radius.html:124:3
374 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't' offset 10,123.98338317871094 
375 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_event_target_radius.html | checking 't' offset -31.416702270507812,10  - got "t", expected "body"
    SimpleTest.is@SimpleTest/SimpleTest.js:310:5
    testMouseClick@layout/base/tests/test_event_target_radius.html:93:5
    runTest@layout/base/tests/test_event_target_radius.html:126:3
376 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't' offset -18.850021362304688,10 
377 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_event_target_radius.html | checking 't' offset 10,-31.416702270507812  - got "t", expected "body"
    SimpleTest.is@SimpleTest/SimpleTest.js:310:5
    testMouseClick@layout/base/tests/test_event_target_radius.html:93:5
    runTest@layout/base/tests/test_event_target_radius.html:128:3
378 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't' offset 10,-18.850021362304688 
379 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't' offset 169.1167449951172,10 
380 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't' offset 169.1167449951172,10 
381 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_event_target_radius.html | checking 't' offset 181.6834259033203,10  - got "t", expected "body"
    SimpleTest.is@SimpleTest/SimpleTest.js:310:5
    testMouseClick@layout/base/tests/test_event_target_radius.html:93:5
    test2@layout/base/tests/test_event_target_radius.html:140:3
382 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't2' offset 169.1167449951172,10 
383 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't2' offset 169.1167449951172,10 
384 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't2' offset 169.1167449951172,10 
385 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't2' offset 169.1167449951172,10 
386 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't2' offset 169.1167449951172,10 
387 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't2' offset 169.1167449951172,10 
388 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_1' offset 169.1167449951172,10 
389 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_2' offset 169.1167449951172,10 
390 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_3' offset 169.1167449951172,10 
391 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_4' offset 169.1167449951172,10 
392 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_5' offset 169.1167449951172,10 
393 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_6' offset 169.1167449951172,10 
394 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_7' offset 169.1167449951172,10 
395 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_8' offset 169.1167449951172,10 
396 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't3_9' offset 169.1167449951172,10 
397 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't4' offset -1,10 
398 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't5_left' offset 102,10 
399 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't5_left' offset 102.5,10 
400 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't5_left' offset 104,10 
401 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't5_left' offset 10,104 
402 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't5_left' offset 10,105 
403 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't5_left' offset 10,106 
404 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner' offset -1,10 
405 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner' offset 39,-1 
406 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner' offset 45,-1 
407 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner_clickable' offset 1,-1 
408 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner_clickable' offset 1,1 
409 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner_clickable' offset 45,-1 
410 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner_clickable' offset 45,1 
411 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_inner_clickable' offset 45,6 
412 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | no point inside t6 that's not within radius of t6_inner; adjust layout of t6/inner/outer as needed
413 INFO TEST-UNEXPECTED-FAIL | layout/base/tests/test_event_target_radius.html | checking 't6_outer' offset -158.3165740966797,-1  - got "t6_inner", expected "t6"
    SimpleTest.is@SimpleTest/SimpleTest.js:310:5
    testMouseClick@layout/base/tests/test_event_target_radius.html:93:5
    test3@layout/base/tests/test_event_target_radius.html:231:3
414 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't6_outer' offset 1,1 
415 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't7' offset 169.1167449951172,10 
416 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't7' offset 10,10 
417 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't8' offset 101,101 
418 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't8' offset 101,101 
419 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't9' offset 101,101 
420 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't9' offset 101,101 
421 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't10_left' offset 51,10 
422 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't10_right' offset 49,10 
423 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't10_top' offset 10,51 
424 INFO TEST-PASS | layout/base/tests/test_event_target_radius.html | checking 't10_bottom' offset 10,49 
425 INFO TEST-OK | layout/base/tests/test_event_target_radius.html | took 10167ms
This probably belongs in Panning and Zooming, since the target radius code isn't really a DOM Events thing. Maybe a Layout thing, but in practice APZ folks have owned this.
Component: DOM: Events → Panning and Zooming
Priority: -- → P3
Whiteboard: [gfx-noted]

We're turning the mouse retargeting back on for Fenix in bug 1618532, so we should ensure related tests are running on Android. Taking this bug to do that.

Assignee: nobody → kats
Priority: P3 → P2
See Also: → 1618532

Got them passing locally, it was a relatively simple fix to properly apply the resolution in the test. Try push to verify:

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=30dedc74ec4cbd001c137b355ddefa112adb1bf5

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4c81e55da90
Improve logging in PositionedEventTargeting slightly. r=snorp
https://hg.mozilla.org/integration/autoland/rev/9b41c7e53caf
Ensure the event retargeting tests pass on Android. r=snorp
https://hg.mozilla.org/integration/autoland/rev/6d313c46b99e
Re-enable event retargeting tests on Android. r=snorp
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: