Closed
Bug 1355869
Opened 7 years ago
Closed 7 years ago
At startup scrollToBottom call takes a good chunk of time
Categories
(DevTools :: Console, enhancement, P1)
DevTools
Console
Tracking
(firefox55 fixed)
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: [console-html])
Attachments
(1 file)
In this profile https://perfht.ml/2o5lA6n there were 2000 messages logged. The scrollToBottom call takes ~300ms when the whole console init is ~2500ms. I saw this took even longer when the components have a bigger height. If the call is delayed to the nextTick (with setTimeout), the call takes ~60ms (https://perfht.ml/2o5oSq8). It would be nice to see if there is any drawbacks of doing this because it looks like an easy win
Assignee | ||
Comment 1•7 years ago
|
||
Here's the scrollToBottom call i'm talking about http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new-console-output/components/console-output.js#42
Comment 2•7 years ago
|
||
I'd be happy with the improvement as long as it doesn't cause an incorrect measurement on isScrolledToBottom (which would cause the console to become 'unpinned').
Updated•7 years ago
|
Blocks: enable-new-console
Updated•7 years ago
|
Flags: qe-verify?
Whiteboard: [new-console] [triage]
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #2) > I'd be happy with the improvement as long as it doesn't cause an incorrect > measurement on isScrolledToBottom (which would cause the console to become > 'unpinned'). I tested it with your stress page (https://bgrins.github.io/devtools-demos/console/stress.html), and everything seems to work fine, since I'm only doing it on the componentDidMount.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Priority: -- → P1
Assignee | ||
Comment 5•7 years ago
|
||
TRY is here https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd778256058f8737df9fcc8a79eb16e4ac015f9e
Updated•7 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [new-console] [triage] → [new-console]
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8857862 [details] Bug 1355869 - Delay scrollToBottom on next tick in console init. https://reviewboard.mozilla.org/r/129490/#review132612 I guess there is a potential race here where a message comes in before the initial scrollToBottom is called, which then fails a check of isScrolledToBottom, but it would be scrolled ultimately anyway once the timeout fires. Looks like a nice perf improvement for minimal change.
Attachment #8857862 -
Flags: review?(bgrinstead) → review+
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8a257ba1903 Delay scrollToBottom on next tick in console init. r=bgrins
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a8a257ba1903
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•7 years ago
|
Iteration: --- → 55.3 - Apr 17
Updated•7 years ago
|
Whiteboard: [new-console] → [console-html]
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•