1355875 - tweak network.http.spdy.timeout to align with google.com

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Patrick McManus [:mcmanus]]

our RecvGoAway telemetry has a shocking amount of reason-code == PROTOCOL_ERROR in it. It turns out most(?) of this is driven by the clean shutdown behavior of google.com after 174 seconds when it responds to 3 pings spaced 58 seconds apart. (just short of 60 second nat barriers).

This shutdown is anticipated, but they send a goaway with protocol_error in it even though this is an implementation decision on their part rather than a reaction to a protocol violation.

This is all rather harmless except it muddies the telemetry waters so we can't figure out what our real error rate is.

as I said at t=174 (where t=0 is the beginning of idle), google initiates shutdown.. but at t=180 we would initiate the shutdown anyhow. The easiest thing to do is to change our timer to be t=170 and pre-empt the google error code and we'll get a clean shutdown.. the connection has reach diminishing returns at this point anyhow - that 4 seconds is rather arbitrary.

I have also opened a conversation with google about them shifting the error code.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: Bug 1355875 - tweak network.http.spdy.timeout to align with google.com

Review commit: https://reviewboard.mozilla.org/r/129498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129498/

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8857522 [details]
Bug 1355875 - tweak network.http.spdy.timeout to align with google.com

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129498/diff/1-2/

Comment 3

[u408661]

Comment on attachment 8857522 [details]
Bug 1355875 - tweak network.http.spdy.timeout to align with google.com

https://reviewboard.mozilla.org/r/129498/#review132566

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/761a4f38fbf1
tweak network.http.spdy.timeout to align with google.com r=nwgh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/761a4f38fbf1