1355882 - Remove Addon Histograms from about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P4)

Description

[Chris H-C :chutten]

But don't do it until at least June 15, 2017.

After bug 1353295 removes addonHistograms we need to wait for 60 days for old pings to age off of users' disks. Then we can remove about:telemetry's ability to display them.

Comment 1

[flyingrub]

Attachment: Bug 1355882 - Remove Addon Histograms from about:telemetry

Removed all code related to Addon Histograms

Review commit: https://reviewboard.mozilla.org/r/132838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132838/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

https://reviewboard.mozilla.org/r/132838/#review135756

There's also a string in toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd that would become unused and can be removed.

As per the bug, though, we cannot do anything about this until the middle of June.

Comment 3

[flyingrub]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132838/diff/1-2/

Comment 4

[flyingrub]

I saw that we cannot do anything for now :).
But I though adding a patch could help for when we could push it.

Comment 5

[Chris H-C :chutten]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

https://reviewboard.mozilla.org/r/132838/#review155150

Comment 6

[flyingrub]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132838/diff/2-3/

Comment 7

[flyingrub]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132838/diff/3-4/

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s d14ba973b759 -d 3e869b1c08d0: rebasing 402631:d14ba973b759 "Bug 1355882 - Remove Addon Histograms from about:telemetry r=chutten" (tip)
merging toolkit/content/aboutTelemetry.css
merging toolkit/content/aboutTelemetry.js
merging toolkit/content/aboutTelemetry.xhtml
merging toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
warning: conflicts while merging toolkit/content/aboutTelemetry.xhtml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[flyingrub]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132838/diff/4-5/

Comment 10

[Chris H-C :chutten]

Comment on attachment 8860845 [details]
Bug 1355882 - Remove Addon Histograms from about:telemetry

https://reviewboard.mozilla.org/r/132838/#review157530

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3489691dd03e
Remove Addon Histograms from about:telemetry r=chutten

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3489691dd03e