Closed
Bug 1355933
Opened 7 years ago
Closed 7 years ago
Add ADTS/AAC sniffer.
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(6 files)
|
59 bytes,
text/x-review-board-request
|
u480271
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
u480271
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
u480271
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
u480271
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
u480271
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
mozbugz
:
review+
|
Details |
This is required for WebAudio to works with AAC in ADTS stream
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857719 [details] Bug 1355933: P1. Replace nsAutoPtr with UniquePtr. https://reviewboard.mozilla.org/r/129654/#review132282
Attachment #8857719 -
Flags: review?(dglastonbury) → review+
|
|
||
Comment 11•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857720 [details] Bug 1355933: P2. Make arguments const. https://reviewboard.mozilla.org/r/129656/#review132284
Attachment #8857720 -
Flags: review?(dglastonbury) → review+
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857724 [details] Bug 1355933: P5. Fix coding style. https://reviewboard.mozilla.org/r/129664/#review132286
Attachment #8857724 -
Flags: review?(gsquelart) → review+
|
|
||
Comment 13•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857721 [details] Bug 1355933: P3. Remove unnecessary duplicated define. https://reviewboard.mozilla.org/r/129658/#review132288
Attachment #8857721 -
Flags: review?(dglastonbury) → review+
|
|
||
Comment 14•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857722 [details] Bug 1355933: P4. Add ADTS sniffer. https://reviewboard.mozilla.org/r/129660/#review132292 ::: dom/media/ADTSDemuxer.h:37 (Diff revision 2) > uint32_t GetNumberTracks(TrackInfo::TrackType aType) const override; > already_AddRefed<MediaTrackDemuxer> > GetTrackDemuxer(TrackInfo::TrackType aType, uint32_t aTrackNumber) override; > bool IsSeekable() const override; > > + // Return true if a valid flac frame header could be found. ... valid *ADTS* frame ... ?
Attachment #8857722 -
Flags: review?(dglastonbury) → review+
|
|
||
Comment 15•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857723 [details] Bug 1355933: P6. Hook up ADTS sniffer. https://reviewboard.mozilla.org/r/129662/#review132296
Attachment #8857723 -
Flags: review?(dglastonbury) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 22•7 years ago
|
||
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7011b23b25d P1. Replace nsAutoPtr with UniquePtr. r=kamidphish https://hg.mozilla.org/integration/autoland/rev/b667b037364a P2. Make arguments const. r=kamidphish https://hg.mozilla.org/integration/autoland/rev/afef0ecf6379 P3. Remove unnecessary duplicated define. r=kamidphish https://hg.mozilla.org/integration/autoland/rev/78187504e4ff P4. Add ADTS sniffer. r=kamidphish https://hg.mozilla.org/integration/autoland/rev/3b6efa74506f P5. Fix coding style. r=gerald https://hg.mozilla.org/integration/autoland/rev/57a42439cc5e P6. Hook up ADTS sniffer. r=kamidphish
|
||
Comment 23•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b7011b23b25d https://hg.mozilla.org/mozilla-central/rev/b667b037364a https://hg.mozilla.org/mozilla-central/rev/afef0ecf6379 https://hg.mozilla.org/mozilla-central/rev/78187504e4ff https://hg.mozilla.org/mozilla-central/rev/3b6efa74506f https://hg.mozilla.org/mozilla-central/rev/57a42439cc5e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•