Closed Bug 1355942 Opened 5 years ago Closed 4 years ago

Intermittent browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js | should have one image - Got 0, expected 1

Categories

(Firefox :: Page Info Window, defect)

Product:
Firefox
Component:
Page Info Window
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: aryx, Assigned: florian)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Fix
1.77 KB, patch
johannh
: review+
Details | Diff | Splinter Review 
https://treeherder.mozilla.org/logviewer.html#?job_id=90983935&repo=mozilla-inbound

10:18:28     INFO - TEST-START | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js
10:18:28     INFO - GECKO(1786) | Chrome file doesn't exist: /builds/slave/test/build/tests/mochitest/browser/browser/base/content/test/pageinfo/head.js
10:18:28     INFO - GECKO(1786) | ++DOCSHELL 0x11d194800 == 2 [pid = 1789] [id = {7dd575ca-2620-2949-9b1f-7b84cfdea3b9}]
10:18:28     INFO - GECKO(1786) | ++DOMWINDOW == 4 (0x11eb86000) [pid = 1789] [serial = 4] [outer = 0x0]
10:18:28     INFO - GECKO(1786) | [Parent 1786] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/caps/BasePrincipal.cpp, line 380
10:18:28     INFO - GECKO(1786) | [Child 1789] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/caps/BasePrincipal.cpp, line 380
10:18:28     INFO - GECKO(1786) | ++DOMWINDOW == 5 (0x11eb8d000) [pid = 1789] [serial = 5] [outer = 0x11eb86000]
10:18:28     INFO - GECKO(1786) | [Child 1789] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/caps/BasePrincipal.cpp, line 380
10:18:28     INFO - GECKO(1786) | [Child 1789] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/caps/BasePrincipal.cpp, line 380
10:18:28     INFO - GECKO(1786) | ++DOMWINDOW == 6 (0x11eb94800) [pid = 1789] [serial = 6] [outer = 0x11eb86000]
10:18:28     INFO - GECKO(1786) | [Child 1789] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/caps/BasePrincipal.cpp, line 380
10:18:28     INFO - GECKO(1786) | [Child 1789] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/caps/BasePrincipal.cpp, line 380
10:18:28     INFO - GECKO(1786) | ++DOCSHELL 0x11911a000 == 11 [pid = 1786] [id = {9a42030c-bded-1242-a8b7-feb590430f6a}]
10:18:28     INFO - GECKO(1786) | ++DOMWINDOW == 22 (0x11e87a800) [pid = 1786] [serial = 22] [outer = 0x0]
10:18:28     INFO - GECKO(1786) | ++DOMWINDOW == 23 (0x127651000) [pid = 1786] [serial = 23] [outer = 0x11e87a800]
10:18:29     INFO - GECKO(1786) | ++DOMWINDOW == 7 (0x11f094800) [pid = 1789] [serial = 7] [outer = 0x11eb86000]
10:18:29     INFO - TEST-INFO | started process screencapture
10:18:29     INFO - TEST-INFO | screencapture: exit 0
10:18:29     INFO - Buffered messages logged at 10:18:29
10:18:29     INFO - Console message: OpenGL compositor Initialized Succesfully.
10:18:29     INFO - Version: 2.1 INTEL-10.6.33
10:18:29     INFO - Vendor: Intel Inc.
10:18:29     INFO - Renderer: Intel Iris OpenGL Engine
10:18:29     INFO - FBO Texture Target: TEXTURE_2D
10:18:29     INFO - TEST-PASS | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js | Image tree is null (media tab is broken) - 
10:18:29     INFO - Buffered messages finished
10:18:29     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js | should have one image - Got 0, expected 1
10:18:29     INFO - Stack trace:
10:18:29     INFO - chrome://mochikit/content/browser-test.js:test_is:928
10:18:29     INFO - chrome://mochitests/content/browser/browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js:test/</</</<:18
10:18:29     INFO - chrome://mochikit/content/browser-test.js:run:954
10:18:29     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "https://example.com/browser/browser/base/content/test/pageinfo/svg_image.html" line: 0}]
this test is failing at a frequent enough failure rate and consistent at 3-5 times/day that we should consider looking at it if there is a quick win.

failures on on opt, not debug.

here is a recent log:
https://treeherder.mozilla.org/logviewer.html#?repo=try&job_id=114946781&lineNumber=1893

and data from the log:
14:10:22     INFO - TEST-START | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js
14:10:22     INFO - TEST-INFO | started process screencapture
14:10:22     INFO - TEST-INFO | screencapture: exit 0
14:10:22     INFO - Buffered messages logged at 14:10:22
14:10:22     INFO - Console message: OpenGL compositor Initialized Succesfully.
14:10:22     INFO - Version: 2.1 INTEL-10.6.33
14:10:22     INFO - Vendor: Intel Inc.
14:10:22     INFO - Renderer: Intel Iris OpenGL Engine
14:10:22     INFO - FBO Texture Target: TEXTURE_2D
14:10:22     INFO - TEST-PASS | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js | Image tree is null (media tab is broken) - 
14:10:22     INFO - Buffered messages finished
14:10:22     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js | should have one image - Got 0, expected 1
14:10:22     INFO - Stack trace:
14:10:22     INFO - chrome://mochikit/content/browser-test.js:test_is:967
14:10:22     INFO - chrome://mochitests/content/browser/browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js:test/</</</<:18
14:10:22     INFO - chrome://mochikit/content/browser-test.js:run:996
14:10:22     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "https://example.com/browser/browser/base/content/test/pageinfo/svg_image.html" line: 0}]
14:10:22     INFO - GECKO(4199) | MEMORY STAT | vsize 4285MB | residentFast 441MB | heapAllocated 166MB
14:10:22     INFO - TEST-OK | browser/base/content/test/pageinfo/browser_pageinfo_svg_image.js | took 679ms


:flo, if there are quick wins we could do to make this test more reliable or fix a bug in the product, it would be nice to see this resolved.
Flags: needinfo?(florian)
(In reply to Joel Maher ( :jmaher) (UTC-8) from comment #6)

> :flo, if there are quick wins we could do to make this test more reliable or
> fix a bug in the product, it would be nice to see this resolved.

I don't see anything obvious unfortunately. Bug 1348544 is likely a different instance of the same underlying problem.

If we believed it's a timing issue in the test, we could add a waitForCondition in the test, but that doesn't really qualify as a 'fix', it's more a way to hide the problem. But I'm really not sure it's a test issue, as browser_pageinfo_images.js is very similar and doesn't have any intermittent failure bug open on it.
Flags: needinfo?(florian)
Attached patch Fix — — Splinter Review
Attachment #8954291 - Flags: review?(jhofmann)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8954291 - Flags: review?(jhofmann) → review+
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbc3980d00d3
Fix intermittent browser_pageinfo_svg_image.js failure by waiting for the load of the correct URI, r=johannh.
https://hg.mozilla.org/mozilla-central/rev/fbc3980d00d3
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.