1355948 - [desktop redirects][li-00137762] Firefox Desktop in-product URLs

Status: RESOLVED INVALID

(support.mozilla.org - Lithium :: General, defect)

Description

[madalina]

This bug is a mirror of Lithium case 00137762: https://supportcases.lithium.com/5006100000AawTs

We have manually created redirects for every localized URL in this document: https://docs.google.com/spreadsheets/d/1bqoCUqsCvdrGTXssavzdadTRF38l8JoIjuEJxqc2QiU/edit?usp=sharing

Please redirect the links in Column D to the Target URL in Column G.

Here is the dialog copied and pasted from the Lithium Support Case system:

BEGIN DIALOG from Case 00137762 ---->

Created By: Kris Stewart (3/24/2017 7:46 PM)

Hi Madalina,

Acknowledged. We'll work on getting the redirects added ASAP, but right now the target is Monday.

Best regards,
Kris

Created By: Kris Stewart (3/27/2017 9:18 AM)

Hi Madalina,

The redirects are now available on your staging instance for review. Would you please spot check a few and let me know if you'd like the changes deployed to production?

Thank you,
Kris

Created By: Sumo Team (3/28/2017 7:53 AM)
Hi Kris:

We may have messed up by giving you support.mozilla.com links to redirect FROM
instead of support.mozilla.org links in column D

What would be the impact on your team to change ALL 6100 redirects to use ".org" instead of ".com" for the FROM links?

Cheers!
...Roland

Created By: Kris Stewart (3/28/2017 9:16 AM)

Hi Roland,

That won't be a problem. After we update the links on stage, would you like to review once more or should we deploy the redirects to production live?

Best regards,
Kris

Created By: SFDC Systems (3/28/2017 10:45 AM)
From: Joni Savage <[e-mail]>

Thanks, Kris. Please go ahead and update the links on stage and we'll
review them ASAP.

Thanks for your help.
Joni

Created By: Kris Stewart (3/28/2017 12:18 PM)

Hi all,

The redirects have been updated on stage for your review.

Best regards,
Kris

Created By: Sumo Team (3/30/2017 12:45 AM)
Hi Kris:

First, thanks for the super-fast turnaround. Much appreciated by SUMO and the Firefox team!

Noticed a few bugs:

1. Same Lithium bug as in the NPAPI case, https://supportcases.lithium.com/5006100000A1zGe aka 00137108

Namely:
There's a bug with non ASCII urls. Something (a non UTF editor?) introducing "illegal" (not sure what is legal in urls and what is not :-))

3 byte encoded characters in the urls instead of using e.g. %706

2 byte encoded characters e.g. %70

e.g.
Lithium is redirecting FROM:
https://support-stage.allizom.org/kb/fxa-managing-devices-zh-CN
TO:
https://support.mozilla.org/t5/Firefox-Sync-Settings/%E7%AE%A1%E706%E4%BD%BF%E74%A8Firefox%E8%B4%A6%E5F%B7%E7A4%E8%AE%BE%E5%A47/ta-p/31225

Note the illegal "%E706" in the above url

The correct URL is:
https://support.mozilla.org/t5/Firefox-Sync-Settings/%E7%AE%A1%E7%90%86%E4%BD%BF%E7%94%A8Firefox%E8%B4%A6%E5%8F%B7%E7%9A%84%E8%AE%BE%E5%A4%87/ta-p/31225

This results in a few hundred errors out of 6000. We encountered the identical problem with the NPAPI
in-product URLs but I guess the Lithium folks
who fixed the NPAPI problem for SUMO didn't communicate that to their colleagues
who did the "6000 line desktop in product redirect URL" spreadsheet :-)

(see full failure report attached, fail-29march2017-test-6000-redirects-results.txt, which shows the failed urls in field 4 and the FROM url in field 3)

2. SUMO copy and paste errors
a) Any URL ending "ja-mac osx" is wrong use "ja-mac" instead
b) Any URL ending "ja linux win" is wrong use "ja" instead
c) 1 URL has a quotation mark i.e. `"` please delete the quotation mark

Please fix 1. and 2.

Cheers!
...Roland

Created By: Kris Stewart (3/30/2017 8:48 AM)

Hi Roland,

Thanks for the detailed feedback as always! I'm working with the team who implemented the redirects to get these issues addressed and noted for any future redirects needed. I'll update again once the changes have been checked in on stage.

Sincerely,
Kris

Created By: Kris Stewart (3/30/2017 5:48 PM)

Hi Roland,

We're addressing the problem with the encoding, but can you please clarify the SUMO issues? I've just reviewed the rewrite map we're using and none of the source URLs we were provided contain "ja-mac osx", but instead contain "ja-JP-mac osx"

Just to confirm, should that be changed to ja-mac or jp-mac?

Thank you,
Kris

Created By: Sumo Team (3/31/2017 1:53 AM)
Hi Kris:

For the redirect FROM URLs
A. "ja-JP-mac osx" should be "ja-JP-mac"
B. "ja linux win32" should be "ja"
C. Also please add a 3rd "ja-JP" FROM URL
D. A-C should all redirect to the same article:
https://support.mozilla.org/t5/%E3%83%97%E3%83%A9%E3%82%A4%E3%83%90%E3%82%B7%E3%83%BC%E3%82%92%E4%BF%9D%E8%AD%B7%E3%81%99%E3%82%8B/%E5%AE%89%E5%85%A8%E3%81%A7%E3%81%AA%E3%81%84%E3%83%9A%E3%83%BC%E3%82%B8%E3%81%AE%E3%83%91%E3%82%B9%E3%83%AF%E3%83%BC%E3%83%89%E3%83%95%E3%82%A3%E3%83%BC%E3%83%AB%E3%83%89%E3%81%A7%E8%AD%A6%E5%91%8A%E3%81%95%E3%82%8C%E3%82%8B/ta-p/38206

Created By: Kris Stewart (3/31/2017 8:16 AM)

Hi all,

We're addressing the remaining failed redirects now and should have them ready for review on stage shortly.

Best regards,
Kris

Created By: SFDC Systems (3/31/2017 10:25 AM)
From: Rachel McGuigan <[e-mail]>
Hi Kris,

I just ran a test and there are about 238 urls that are failing because of
the uni code bug mentioned before.

I have attached the errors and have started to investigate them - please
use it for reference.

Created By: Kris Stewart (3/31/2017 11:04 AM)
Hi all,

We're nearly done with the redirects on stage but need further clarification on the following:

C. Also please add a 3rd "ja-JP" FROM URL

The current list has no source values that contain only "ja-JP". Could we please get a list of articles for that request to be redirected to the 38206 article?

Thank you,
Kris

Created By: Sumo Team (3/31/2017 12:32 PM)
Hi Kris

You wrote:
"
The current list has no source values that contain only "ja-JP". Could we please get a list of articles for that request to be redirected to the 38206 article?
"

Sorry for not being clear to you and Rachel
Please redirect
FROM

https://support.mozilla.org/kb/insecure-password-warning-firefox-ja-JP
(of course change "support.mozilla" to "support-stage.allizom" for testing on stage)

TO:

https://support.mozilla.org/t5/%E3%83%97%E3%83%A9%E3%82%A4%E3%83%90%E3%82%B7%E3%83%BC%E3%82%92%E4%BF%9D%E8%AD%B7%E3%81%99%E3%82%8B/%E5%AE%89%E5%85%A8%E3%81%A7%E3%81%AA%E3%81%84%E3%83%9A%E3%83%BC%E3%82%B8%E3%81%AE%E3%83%91%E3%82%B9%E3%83%AF%E3%83%BC%E3%83%89%E3%83%95%E3%82%A3%E3%83%BC%E3%83%AB%E3%83%89%E3%81%A7%E8%AD%A6%E5%91%8A%E3%81%95%E3%82%8C%E3%82%8B/ta-p/38206 

Created By: Chad Beatty (3/31/2017 12:42 PM)

Hi Rachel & Roland,

Thanks for the updates. We do have rewrites for these working on stage:

https://support-stage.allizom.org/kb/insecure-password-warning-firefox-ja
https://support-stage.allizom.org/kb/insecure-password-warning-firefox-ja-JP
https://support-stage.allizom.org/kb/insecure-password-warning-firefox-ja-JP-mac

We tested and confirmed these are working as expected on staging, can you please verify? There was an issue with the latter rewrite that we just addressed. We verified that we do not have any rewrites containing "ja-mac osx" or "ja linux win".

Best,
Chad


Created By: SFDC Systems (4/2/2017 10:30 PM)
From: Rachel McGuigan <[e-mail]>

Hi there,

We consider these links to be an outage fro a majority of users. They are
in-product live links, please escalate this or provide an update.

Thank you,
Rachel

Created By: Kris Stewart (4/3/2017 12:42 PM)

Hi all,

We've made updates based on your previous feedback. The rewrites are currently ready for review on stage, so assuming everything is working as expected, we can push them out to production live if/once you give the green light. If anything is not functioning as expected, please let me know as well and we'll work on correcting them today.

Best regards,
Kris


Created By: SFDC Systems (4/6/2017 9:40 AM)
From: Patrick McClard <[e-mail]>

Hey Kris,

Can you push these redirects to production now.

Thanks,
Patrick

Created By: Kris Stewart (4/6/2017 12:01 PM)

Hi Patrick,

Sorry for the confirmation - we're rolling it out here very shortly and will update once the redirects are live.

Sincerely,
Kris


Created By: Kris Stewart (4/6/2017 12:23 PM)

Hi Patrick,

The redirects are now live on production.

Best regards,
Kris

Created By: SFDC Systems (4/6/2017 3:54 PM)
From: Patrick McClard <[e-mail]>

Thanks Kris. Most of the URLs are working, but we're seeing 2 errors.

1. We have pages that are redirecting to the wrong id (we say id 1000, they
redirect to 2000)
https://github.com/bensternthal/sumo-redirect/blob/master/completed_log_
runs/2017_04_06/failureLog_id-mismatch-only.txt

2. Pages that have a # in the url seem to be not going to the right spot
https://github.com/bensternthal/sumo-redirect/blob/master/completed_log_
runs/2017_04_06/failureLog_hash-issue-only.txt

Here's a spreadsheet that contains these 2 lists on 2 sheets. Can you fix
these redirects, it should go 'From in-product link' and redirect to the
'Expected URL' column.

https://docs.google.com/spreadsheets/d/1OJ04XOeuu8RMFLytz3I5KoVJ_r1Gh6sj-bJS2h64MlQ/edit?usp=sharing

If you can get these up we will be ready to test them in the AM.


Created By: SFDC Systems (4/7/2017 9:58 AM)
From: Patrick McClard <[e-mail]>

Hey Kris,

Just following up. Can we get confirmation this is being worked on and when
we can expect being able to test these final 797 links?



Created By: Kris Stewart (4/7/2017 4:17 PM)
Hi all,

We've just finished cleaning up the file to implement the existing workarounds and are in the process of deploying them on staging now. We'll update again today once they're live on stage.

Best regards,
Kris

Created By: Kris Stewart (4/7/2017 10:26 PM)
Hi all,

I apologize for the delays, but we had to work on preparing Akamai and disabling mitigation. However, these redirects have been updated on stage and deployed live to production. We deployed them given the majority of them were already set as requested and the ja / ja-JP-mac links just needed a few adjustments.

Best regards,
Kris

Created By: Sumo Team (4/10/2017 1:24 PM)
Hi Kris:

We found approximately 600 errors and will be submitting two spreadsheets of corrections (the approximately 5000 rest of the links, worked, thanks!)

Correction Spreadsheet 1 Please redirect from Column A to Column B
https://docs.google.com/spreadsheets/d/1KUjga4toyvBOAKHF2zzErTUj0yySubXDWrgh6Zv9KOc/edit#gid=478093903

We plan on submitting Correction Spreadsheet 2 by the end of the day Monday April 10, 2017

Cheers!
....Roland


Created By: Sumo Team (4/10/2017 5:39 PM)
Hi Lithium folks

As per our comment from 4/10/2017 1:24 PM, here is spreadsheet 2 with the remainder of the 600 redirects for today Monday April 10, 2017:
https://docs.google.com/spreadsheets/d/1oyIVIk5BZUvrHUPPu8LOHXYsfoZ3W_0GBF4PV8bVwIE/edit?ts=58ebc370#gid=255038899

Please redirect from Column A to Column B
Cheers!
...Roland

Created By: Kris Stewart (4/10/2017 7:06 PM)

Hi Roland,

I have access to the first doc and we're working on that batch, but the second and most recent doc is private and I'm unable to access it. Would you please grant access ?

Thank you,
Kris


Created By: Sumo Team (4/10/2017 7:09 PM)
Hi Kris:

My apologies
I have made the spreadsheet 2 at:
https://docs.google.com/spreadsheets/d/1oyIVIk5BZUvrHUPPu8LOHXYsfoZ3W_0GBF4PV8bVwIE/edit?usp=sharing

viewable by all including yourself!

Cheers!
...Roland

Created By: Kris Stewart (4/10/2017 7:11 PM)

Hi Roland,

Got it - I've downloaded sheet 2. We'll let you know once these have been updated on stage, but they're being worked on now.

Best regards,
Kris

Created By: Kris Stewart (4/11/2017 10:42 AM)

Hi Madalina,

We've just finished implementing the redirects on stage for review. Please note that if you encounter 404 errors when being redirected, that's due to the content/article not existing on stage.

We can deploy this live to production once/if we receive the green light.

Best regards,
Kris

Created By: Sumo Team (4/11/2017 2:09 PM)
Hi Kris and Lithium folks:

1. We see 18 failures in Spreadsheet 1:
https://github.com/rtanglao/rt-li-sumo-redirects/blob/master/FAIL-STAGE-stdout.11april2017-spreadsheet1.md
Can you please fix these 18 failures ASAP? (but thanks for the approx. 200 that now now pass!)

2. Please REDO spreadsheet 2:
https://docs.google.com/spreadsheets/d/1oyIVIk5BZUvrHUPPu8LOHXYsfoZ3W_0GBF4PV8bVwIE/edit?usp=sharing
It appears you only partially did spreadsheet 2?!?!? We see only 4 PASS:
https://github.com/rtanglao/rt-li-sumo-redirects/blob/master/PASS-STAGE-stdout.11april2017-spreadsheet2.md
and 465 FAIL:
https://github.com/rtanglao/rt-li-sumo-redirects/blob/master/FAIL-STAGE-stdout.11april2017-spreadsheet2.md

Cheers!
...Roland

Created By: Kris Stewart (4/12/2017 7:51 AM)

Hi Madalina,

The work is done, the redirects just need to be deployed. Part of the problem with the second batch of redirects failing was due to the content not existing on stage, so we're planning to deploy these soon given they're just updates to preexisting redirects.

I'll shoot you over another update once the changes are live.

Thank you,
Kris

END DIALOG from Case 00137762

Comment 1

[madalina]

Update

Created By: Kris Stewart (4/12/2017 8:44 AM)

Hi all,

The redirects have been updated on production. Would you please have a look and let us know if everything hitting the correct destinations?

Thank you,
Kris

Comment 2

[madalina]

Testing revealed 465 still don't work (looks like anchor links).

Re-escalated to Lithium.