Closed
Bug 1355961
Opened 7 years ago
Closed 7 years ago
Include some sccache stats in build_metrics
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: ted, Assigned: ted)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I'd like to get some stats out of sccache into Perfherder. As a first cut I'm adding cache hit rate, cache write errors, and non-cacheable requests (compiler invocations that sccache can't handle). This should let us monitor some things that will hamper build times.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33586777235fbaddf2b5c2e6885cc84f50c736cf
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=33586777235fbaddf2b5c2e6885cc84f50c736cf That didn't work. I think I'm putting the stats JSON in the wrong place.
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8857620 [details] bug 1355961 - add some sccache stats to build_metrics. https://reviewboard.mozilla.org/r/129580/#review132210 The only potential issue I see with this is what happens in case of failure loading the JSON file. If that raises an exception, that could fail the build. I like failing fast. But if there are any cases where the stats file isn't produced, this could bite us.
Attachment #8857620 -
Flags: review?(gps) → review+
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3) > That didn't work. I think I'm putting the stats JSON in the wrong place. Oh, hah! In Makefile.in I wrote "sccache-stats.json", but in buildbase.py I wrote "sccache_stats.json".
Assignee | ||
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f89685fd34dd424e81f695e355f742a59e7b65d2
Assignee | ||
Comment 7•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfb76275fa9c45d95b803629ced8ef3078f8bf1d
Assignee | ||
Comment 8•7 years ago
|
||
OK, that's better: sccache cache_write_errors summary opt taskcluster-m4.4xlarge: 0 sccache hit rate summary opt taskcluster-m4.4xlarge: 1 sccache requests_not_cacheable summary opt taskcluster-m4.4xlarge: 49 sccache cache_write_errors summary debug taskcluster-m4.4xlarge: 2 sccache hit rate summary debug taskcluster-m4.4xlarge: 1 sccache requests_not_cacheable summary debug taskcluster-m4.4xlarge: 49
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=67a5a35d88f28c7103a648870bfc602ea08c2939
Assignee | ||
Comment 10•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5552791f6c8da640cfcb248ba4681d4d31594a5 bug 1355961 - add some sccache stats to build_metrics. r=gps
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b5552791f6c8
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Blocks: buildmetrics
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•