String Changes to about:preferences#general

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Preferences
VERIFIED FIXED
4 months ago
4 months ago

People

(Reporter: JW_SoftvisionQA, Assigned: jaws)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

(URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Per Specs: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167547

Remove Colon:

Startup Section:
When Firefox starts
Home Page

Fonts & Colors Section:
Default font
Size

Capitalization:
One-Click Search Engines Section:
One-Click Search Engines

Remove Ellipsis:

One-Click Search Engines Section:
Add more search engines

Move to Performance Section:

Browsing Section:
Use hardware acceleration when available
(Reporter)

Updated

4 months ago
Blocks: 1335907
Hey flod, 

For this bug, as well as bug 1356008, bug 1356009, bug 1356020, and bug 1356021, I'm planning on not changing the string entity names for the string changes that remove the colon, ellipsis, or change capitalization. Is that OK with you? If so, then should we send an email to the l10n mailing list to announce that these minor typographical changes have been made but no verbiage changes were made?

As always, the changes that require changing the verbiage will also get new string IDs.
Flags: needinfo?(francesco.lodolo)
Capitalization changes are definitely fine without new IDs.

Removing colons and ellipsis not so much: I expect all locales to follow en-US lead in that, updating without a new string ID will cause visual inconsistencies in everything but en-US, unless localizers carefully match these changes. It's a matter of deciding if that's acceptable.

Sending out a list is going to be helpful only up to a certain point, people will need to see the warning in the first place, then manually search for these strings and update them. Painful and fragile.

My advice would be to update the string ID in these cases, sadly it will cause churn in code, but we don't have a better solution as of today. We've been putting some thoughts on how to avoid this in l20n, but we're still a long way from finding a solution (or having l20n in Firefox).
Flags: needinfo?(francesco.lodolo)
(Assignee)

Updated

4 months ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Spec for General pane: https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/217167547
(Assignee)

Updated

4 months ago
Blocks: 1324168
No longer blocks: 1335907

Comment 5

4 months ago
mozreview-review
Comment on attachment 8858220 [details]
Bug 1356006 - Fix inconsistencies with strings in about:preferences#general.

https://reviewboard.mozilla.org/r/130178/#review132970
Attachment #8858220 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 6

4 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/daf1d4c316ad
Fix inconsistencies with strings in about:preferences#general. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/daf1d4c316ad
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 8

4 months ago
I have seen the previous strings in firefox nightly 55.0a1 (2017-04-12)on Windows 10(64Bit). 


I can verify that the strings has been fixed in latest nightly 55.0a1 .

Build ID 	20170420030346
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[Bugday-20170419]
(Assignee)

Updated

4 months ago
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.