1356013 - Intermittent font-face/media-query-add-1.html == http://localhost:39929/1492020038431/238/font-face/media-query-add-1.html | image comparison, max difference: 255, number of differing pixels: 239

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=91023966&repo=autoland

https://queue.taskcluster.net/v1/task/bugW4WlsTfKDbtobgb6hEg/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/bugW4WlsTfKDbtobgb6hEg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 1

[Intermittent Failures Robot]

24 failures in 205 pushes (0.117 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 19
* mozilla-inbound: 3
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64-stylo: 24

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-13&endday=2017-04-13&tree=all

Comment 2

[Intermittent Failures Robot]

17 failures in 155 pushes (0.11 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 11
* mozilla-inbound: 6

Platform breakdown:
* linux64-stylo: 17

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-14&endday=2017-04-14&tree=all

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

this is failing quite frequently as per some retriggers:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=stylo%20reftest%20opt%20rs9&tochange=3c6b8512d77fd4c6556c53a83c556df4aac03559&fromchange=819f8b4c80b67a383195875999b07fb9f484c1b4&selectedJob=91023966

I strongly suspect this is related to some media query changes that landed in stylo during the stylo build breakage:
https://github.com/servo/servo/pull/16378

here is the reftest analyzer view:
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/bugW4WlsTfKDbtobgb6hEg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


:emilio can you have a look at this?

Comment 4

[Intermittent Failures Robot]

53 failures in 894 pushes (0.059 failures/push) were associated with this bug in the last 7 days. 

This is the #27 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 37
* mozilla-inbound: 14
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64-stylo: 53

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-10&endday=2017-04-16&tree=all

Comment 5

[Intermittent Failures Robot]

16 failures in 159 pushes (0.101 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 13
* mozilla-inbound: 3

Platform breakdown:
* linux64-stylo: 16

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-18&endday=2017-04-18&tree=all

Comment 6

[Intermittent Failures Robot]

20 failures in 186 pushes (0.108 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 11
* mozilla-inbound: 7
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64-stylo: 20

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-19&endday=2017-04-19&tree=all

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: temporarily disable test on stylo

as we are hitting 100+/week and no information in the bug regarding a pending fix, lets disable this until we can get a fix

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4c3713d1933
Intermittent font-face/media-query-add-1.html. skip on stylo. r=gbrown

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4c3713d1933

Comment 10

[Intermittent Failures Robot]

15 failures in 138 pushes (0.109 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 13
* mozilla-inbound: 2

Platform breakdown:
* linux64-stylo: 15

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-20&endday=2017-04-20&tree=all

Comment 11

[Intermittent Failures Robot]

70 failures in 817 pushes (0.086 failures/push) were associated with this bug in the last 7 days. 

This is the #8 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 49
* mozilla-inbound: 17
* mozilla-central: 3
* try: 1

Platform breakdown:
* linux64-stylo: 70

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1356013&startday=2017-04-17&endday=2017-04-23&tree=all

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Sorry for the radio silence here. This is probably uncovered by those media query fixes you mentioned, but seems more related to @font-face (there are similar disabled tests right before it).

I'm not aware of the details of that, Xidorn, any idea here?

Comment 13

[Xidorn Quan [:xidorn] UTC+10]

@font-face rules are gathered from ServoStyleSet::AppendFontFaceRules() [1] for Gecko code, and they are collected in Stylist::rebuild() [2], so we need to rebuild Stylist for device change to make it work properly.

It seems to me that mStylistMayNeedRebuild isn't set for device changes, and thus MaybeRebuildStylist doesn't seem to actually update the stylist when calling AppendFontFaceRules. Could that be an issue?

Anything outside AppendFontFaceRules() should be shared between Gecko and Stylo for layout, and thus shouldn't cause such mismatch I suppose...


[1] http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/layout/style/ServoStyleSet.cpp#1050
[2] http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/servo/components/style/stylist.rs#306

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Hmm... how doesn't it?

In nsPresContext::MediumFeatureValuesChanged, we end up calling RebuildAllStyleData[1].

That goes, through a series of hops, to ServoStyleSet::RebuildData(), which calls into servo and ends up at reset_device[2], which does a synchronous flush. So I'm not sure how could that happen.

That being said, the code has changed a bit lately, and this test has been disabled for ~20 days already, so perhaps it's not an issue anymore and we should try to re-enable it?

[1]: http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/layout/base/nsPresContext.cpp#2071
[2]: http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/servo/components/style/gecko/data.rs#93

Comment 15

[Xidorn Quan [:xidorn] UTC+10]

Locally I'm seeing an unexpected scrollbar...

Perhaps this test consistently fails because of that :/

Given it is still not passing, I guess it isn't worth trying re-enabling it at the moment.

Comment 16

[Chris Peterson [:cpeterson]]

Resolving intermittent Stylo test failure bugs that haven't recurred within the last month.

Comment 17

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.