Intermittent font-face/media-query-add-1.html == http://localhost:39929/1492020038431/238/font-face/media-query-add-1.html | image comparison, max difference: 255, number of differing pixels: 239

RESOLVED WORKSFORME

Status

()

P5
normal
RESOLVED WORKSFORME
2 years ago
10 months ago

People

(Reporter: intermittent-bug-filer, Unassigned)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [stockwell disabled])

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
this is failing quite frequently as per some retriggers:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=stylo%20reftest%20opt%20rs9&tochange=3c6b8512d77fd4c6556c53a83c556df4aac03559&fromchange=819f8b4c80b67a383195875999b07fb9f484c1b4&selectedJob=91023966

I strongly suspect this is related to some media query changes that landed in stylo during the stylo build breakage:
https://github.com/servo/servo/pull/16378

here is the reftest analyzer view:
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/bugW4WlsTfKDbtobgb6hEg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1


:emilio can you have a look at this?
Flags: needinfo?(emilio+bugs)
Whiteboard: [stockwell needswork]
Priority: -- → P5
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Created attachment 8859996 [details] [diff] [review]
temporarily disable test on stylo

as we are hitting 100+/week and no information in the bug regarding a pending fix, lets disable this until we can get a fix
Attachment #8859996 - Flags: review?(gbrown)
Attachment #8859996 - Flags: review?(gbrown) → review+

Comment 8

2 years ago
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4c3713d1933
Intermittent font-face/media-query-add-1.html. skip on stylo. r=gbrown
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Sorry for the radio silence here. This is probably uncovered by those media query fixes you mentioned, but seems more related to @font-face (there are similar disabled tests right before it).

I'm not aware of the details of that, Xidorn, any idea here?
Flags: needinfo?(emilio+bugs) → needinfo?(xidorn+moz)
@font-face rules are gathered from ServoStyleSet::AppendFontFaceRules() [1] for Gecko code, and they are collected in Stylist::rebuild() [2], so we need to rebuild Stylist for device change to make it work properly.

It seems to me that mStylistMayNeedRebuild isn't set for device changes, and thus MaybeRebuildStylist doesn't seem to actually update the stylist when calling AppendFontFaceRules. Could that be an issue?

Anything outside AppendFontFaceRules() should be shared between Gecko and Stylo for layout, and thus shouldn't cause such mismatch I suppose...


[1] http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/layout/style/ServoStyleSet.cpp#1050
[2] http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/servo/components/style/stylist.rs#306
Flags: needinfo?(xidorn+moz) → needinfo?(emilio+bugs)
Hmm... how doesn't it?

In nsPresContext::MediumFeatureValuesChanged, we end up calling RebuildAllStyleData[1].

That goes, through a series of hops, to ServoStyleSet::RebuildData(), which calls into servo and ends up at reset_device[2], which does a synchronous flush. So I'm not sure how could that happen.

That being said, the code has changed a bit lately, and this test has been disabled for ~20 days already, so perhaps it's not an issue anymore and we should try to re-enable it?

[1]: http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/layout/base/nsPresContext.cpp#2071
[2]: http://searchfox.org/mozilla-central/rev/06b337ab22d40e12c4cde8040b23147ea636cc6e/servo/components/style/gecko/data.rs#93
Flags: needinfo?(emilio+bugs) → needinfo?(xidorn+moz)
Locally I'm seeing an unexpected scrollbar...

Perhaps this test consistently fails because of that :/

Given it is still not passing, I guess it isn't worth trying re-enabling it at the moment.
Flags: needinfo?(xidorn+moz)
No longer blocks: 1341102
Resolving intermittent Stylo test failure bugs that haven't recurred within the last month.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WORKSFORME
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.