Closed
Bug 1356014
Opened 7 years ago
Closed 7 years ago
Intermittent dom/workers/test/serviceworkers/test_devtools_serviceworker_interception.html | undefined assertion name
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: bhsu)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:logic])
Attachments
(1 file, 1 obsolete file)
2.12 KB,
patch
|
bhsu
:
review+
|
Details | Diff | Splinter Review |
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=90986014&repo=autoland https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win32-debug/1492010588/autoland_win7_ix-debug_test-mochitest-chrome-2-bm112-tests1-windows-build159.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Blocks: ServiceWorkers-tests
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 10•7 years ago
|
||
this failure is occurring at a fairly high frequency, primarily on opt and non-e10s. :overholt, can you find someone on the service workers team to look into this?
Flags: needinfo?(overholt)
Whiteboard: [stockwell needswork]
Comment 11•7 years ago
|
||
Catalin, can you please take a look?
Flags: needinfo?(overholt) → needinfo?(catalin.badea392)
Comment hidden (Intermittent Failures Robot) |
Comment 13•7 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #11) > Catalin, can you please take a look? Ho-Pang might be more familiar with this code. Do you have time to take this?
Flags: needinfo?(catalin.badea392) → needinfo?(bhsu)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bhsu
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 16•7 years ago
|
||
Assignee | ||
Comment 17•7 years ago
|
||
Comment on attachment 8889302 [details] [diff] [review] Fix an intermittent failure on try Hi Ben, Though I failed to reproduce this both locally and on Try, I still wrote this patch. By counting the position of this error, I think we are checking the wrong network event as the comment in the patch describes. I humbly suggest we can land this patch and see whether the failure reduces.
Attachment #8889302 -
Flags: review?(bkelly)
Updated•7 years ago
|
Attachment #8889302 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 18•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b20f2bec08fbe083d30ec044bc0580c2816db979&selectedJob=118305130
Keywords: checkin-needed
Comment 19•7 years ago
|
||
Please provide a better commit message for this patch. http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages
Keywords: checkin-needed
Updated•7 years ago
|
Flags: needinfo?(bhsu)
Assignee | ||
Comment 20•7 years ago
|
||
Refine the commit message.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(bhsu)
Attachment #8891218 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Attachment #8889302 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 21•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9dcc2cad70 Wait for appearance of the desired channel to do the related checks. r=bkelly
Keywords: checkin-needed
Comment 22•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ac9dcc2cad70
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell needswork:DOM] → [stockwell fixed:logic]
You need to log in
before you can comment on or make changes to this bug.
Description
•