Closed Bug 1356014 Opened 5 years ago Closed 4 years ago
_devtools _serviceworker _interception .html | undefined assertion name
this failure is occurring at a fairly high frequency, primarily on opt and non-e10s. :overholt, can you find someone on the service workers team to look into this?
Whiteboard: [stockwell needswork]
Catalin, can you please take a look?
Flags: needinfo?(overholt) → needinfo?(catalin.badea392)
(In reply to Andrew Overholt [:overholt] from comment #11) > Catalin, can you please take a look? Ho-Pang might be more familiar with this code. Do you have time to take this?
Flags: needinfo?(catalin.badea392) → needinfo?(bhsu)
Sure, I'll do my best ;)
Comment on attachment 8889302 [details] [diff] [review] Fix an intermittent failure on try Hi Ben, Though I failed to reproduce this both locally and on Try， I still wrote this patch. By counting the position of this error, I think we are checking the wrong network event as the comment in the patch describes. I humbly suggest we can land this patch and see whether the failure reduces.
Attachment #8889302 - Flags: review?(bkelly)
Attachment #8889302 - Flags: review?(bkelly) → review+
Please provide a better commit message for this patch. http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages
Refine the commit message.
Attachment #8891218 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9dcc2cad70 Wait for appearance of the desired channel to do the related checks. r=bkelly
Whiteboard: [stockwell needswork:DOM] → [stockwell fixed:logic]
You need to log in before you can comment on or make changes to this bug.