Closed Bug 1356014 Opened 2 years ago Closed 2 years ago

Intermittent dom/workers/test/serviceworkers/test_devtools_serviceworker_interception.html | undefined assertion name

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bhsu)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:logic])

Attachments

(1 file, 1 obsolete file)

this failure is occurring at a fairly high frequency, primarily on opt and non-e10s.

:overholt, can you find someone on the service workers team to look into this?
Flags: needinfo?(overholt)
Whiteboard: [stockwell needswork]
Catalin, can you please take a look?
Flags: needinfo?(overholt) → needinfo?(catalin.badea392)
(In reply to Andrew Overholt [:overholt] from comment #11)
> Catalin, can you please take a look?

Ho-Pang might be more familiar with this code.

Do you have time to take this?
Flags: needinfo?(catalin.badea392) → needinfo?(bhsu)
Sure, I'll do my best ;)
Flags: needinfo?(bhsu)
Assignee: nobody → bhsu
Comment on attachment 8889302 [details] [diff] [review]
Fix an intermittent failure on try

Hi Ben,

Though I failed to reproduce this both locally and on Try, I still wrote this patch. By counting the position of this error, I think we are checking the wrong network event as the comment in the patch describes. I humbly suggest we can land this patch and see whether the failure reduces.
Attachment #8889302 - Flags: review?(bkelly)
Attachment #8889302 - Flags: review?(bkelly) → review+
Flags: needinfo?(bhsu)
Flags: needinfo?(bhsu)
Attachment #8891218 - Flags: review+
Attachment #8889302 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9dcc2cad70
Wait for appearance of the desired channel to do the related checks. r=bkelly
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ac9dcc2cad70
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Whiteboard: [stockwell needswork:DOM] → [stockwell fixed:logic]
You need to log in before you can comment on or make changes to this bug.