Closed Bug 1356023 Opened 3 years ago Closed 3 years ago

Remove nsIScreenManager.systemDefaultScale

Categories

(Core :: Widget, enhancement)

50 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: emk, Assigned: emk)

References

Details

(Keywords: addon-compat)

Attachments

(1 file)

This property is very inconsistent between platforms. On macOS and mobile, it will always return 1.0. It will take into account DefaultScaleOverride() on Linux while it does not on Windows.

This property was added for ease of migration (see bug 851520). But it was not used when Gtk widget supported high DPI.

I think this property will only confuse people now.
Some default-zoom-tweaking addons will be affected.
Keywords: addon-compat
Comment on attachment 8857884 [details]
Bug 1356023 - Remove nsIScreenManager.systemDefaultScale.

https://reviewboard.mozilla.org/r/129626/#review132924

Yes, I think we can consider this obsolete and get rid of it.
Attachment #8857884 - Flags: review?(jfkthame) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2758e4140ece -d 9e9398d512bd: rebasing 389971:2758e4140ece "Bug 1356023 - Remove nsIScreenManager.systemDefaultScale. r=jfkthame" (tip)
merging browser/components/nsBrowserGlue.js
merging widget/PuppetWidget.cpp
warning: conflicts while merging browser/components/nsBrowserGlue.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/9ad613f8801a
Remove nsIScreenManager.systemDefaultScale. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/9ad613f8801a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.