Remove nsIScreenManager.systemDefaultScale

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

({addon-compat})

50 Branch
mozilla55
addon-compat
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This property is very inconsistent between platforms. On macOS and mobile, it will always return 1.0. It will take into account DefaultScaleOverride() on Linux while it does not on Windows.

This property was added for ease of migration (see bug 851520). But it was not used when Gtk widget supported high DPI.

I think this property will only confuse people now.
(Assignee)

Comment 1

2 years ago
Some default-zoom-tweaking addons will be affected.
Keywords: addon-compat
Comment hidden (mozreview-request)
Comment on attachment 8857884 [details]
Bug 1356023 - Remove nsIScreenManager.systemDefaultScale.

https://reviewboard.mozilla.org/r/129626/#review132924

Yes, I think we can consider this obsolete and get rid of it.
Attachment #8857884 - Flags: review?(jfkthame) → review+

Comment 4

2 years ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2758e4140ece -d 9e9398d512bd: rebasing 389971:2758e4140ece "Bug 1356023 - Remove nsIScreenManager.systemDefaultScale. r=jfkthame" (tip)
merging browser/components/nsBrowserGlue.js
merging widget/PuppetWidget.cpp
warning: conflicts while merging browser/components/nsBrowserGlue.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED

Comment 6

2 years ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/9ad613f8801a
Remove nsIScreenManager.systemDefaultScale. r=jfkthame
https://hg.mozilla.org/mozilla-central/rev/9ad613f8801a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.