Closed Bug 1356030 Opened 8 years ago Closed 8 years ago

HiddenFrame.jsm should move to toolkit so it's available on android

Categories

(Toolkit :: General, defect)

55 Branch
All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: JanH, Assigned: Gijs)

References

Details

Attachments

(1 file)

Can't give any specific STR, but with an SDK add-on installed and enabled, I'm eventually seeing something like this: > 04-13 00:17:14.218 8808 8828 E GeckoConsole: [JavaScript Error: "A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'? > 04-13 00:17:14.218 8808 8828 E GeckoConsole: See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise > 04-13 00:17:14.218 8808 8828 E GeckoConsole: > 04-13 00:17:14.218 8808 8828 E GeckoConsole: Date: Thu Apr 13 2017 00:17:12 GMT+0200 (CEST) > 04-13 00:17:14.218 8808 8828 E GeckoConsole: Full Message: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js :: _require :: line 773" data: no] > 04-13 00:17:14.218 8808 8828 E GeckoConsole: Full Stack: @undefined:773:undefined > 04-13 00:17:14.218 8808 8828 E GeckoConsole: @resource://gre/modules/commonjs/sdk/addon/window.js:15:25 > 04-13 00:17:14.218 8808 8828 E GeckoConsole: startup/<@resource://gre/modules/commonjs/sdk/addon/runner.js:72:21 > 04-13 00:17:14.218 8808 8828 E GeckoConsole: process@resource://gre/modules/Promise-backend.js:922:23 > 04-13 00:17:14.218 8808 8828 E GeckoConsole: walkerLoop@resource://gre/modules/Promise-backend.js:806:7 > 04-13 00:17:14.218 8808 8828 E GeckoConsole: scheduleWalkerLoop/<@resource://gre/modules/Promise-backend.js:742:11 > 04-13 00:17:14.218 8808 8828 E GeckoConsole: "] Probably HiddenFrame.jsm needs moving to Toolkit?
Flags: needinfo?(gijskruitbosch+bugs)
Hm. I guess we should move HiddenFrame.jsm to toolkit.
(In reply to Kris Maglione [:kmag] from comment #2) > Except, of course... :( > > https://dxr.mozilla.org/addons/search?q=HiddenFrame.jsm > > And this is a bit worrisome... > > https://dxr.mozilla.org/addons/source/addons/751348/test/omni/modules/ > SelfSupportBackend.jsm Huh, that looks like it's just a copy of the SelfSupportBackend.jsm we ship. https://dxr.mozilla.org/addons/source/addons/751348/install.rdf doesn't really help elucidate what kind of add-on this is. :-\
The only other add-on hit seems to be https://addons.mozilla.org/en-US/firefox/addon/super-start/ , which also isn't e10s-compatible... So I think we should just move it.
Yeah, agreed
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Product: Firefox for Android → Toolkit
Summary: HiddenFrame.jsm missing on Android? → HiddenFrame.jsm should move to toolkit so it's available on android
This presumably also explains the test failure on android which I, in my ignorance, just disabled :-\ Not part of the patch as submitted for review yet, but here's a trypush to check it: remote: https://treeherder.mozilla.org/#/jobs?repo=try&revision=585497447efd6d2a6076f98b3bf4e4a2e60096c9
(In reply to :Gijs from comment #7) > This presumably also explains the test failure on android which I, in my > ignorance, just disabled :-\ > > Not part of the patch as submitted for review yet, but here's a trypush to > check it: > > remote: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=585497447efd6d2a6076f98b3bf4e4a2e60096c9 It's green, so updating the patch to include this. :-)
Attachment #8857889 - Flags: review?(kmaglione+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: