1356030 - HiddenFrame.jsm should move to toolkit so it's available on android

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jan Henning [:JanH]]

Can't give any specific STR, but with an SDK add-on installed and enabled, I'm eventually seeing something like this:

> 04-13 00:17:14.218  8808  8828 E GeckoConsole: [JavaScript Error: "A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: 
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: Date: Thu Apr 13 2017 00:17:12 GMT+0200 (CEST)
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: Full Message: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js :: _require :: line 773"  data: no]
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: Full Stack: @undefined:773:undefined
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: @resource://gre/modules/commonjs/sdk/addon/window.js:15:25
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: startup/<@resource://gre/modules/commonjs/sdk/addon/runner.js:72:21
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: process@resource://gre/modules/Promise-backend.js:922:23
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: walkerLoop@resource://gre/modules/Promise-backend.js:806:7
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: scheduleWalkerLoop/<@resource://gre/modules/Promise-backend.js:742:11
> 04-13 00:17:14.218  8808  8828 E GeckoConsole: "]

Probably HiddenFrame.jsm needs moving to Toolkit?

Comment 1

[Kris Maglione [:kmag]]

Hm. I guess we should move HiddenFrame.jsm to toolkit.

Comment 2

[Kris Maglione [:kmag]]

Except, of course... :(

https://dxr.mozilla.org/addons/search?q=HiddenFrame.jsm

And this is a bit worrisome...

https://dxr.mozilla.org/addons/source/addons/751348/test/omni/modules/SelfSupportBackend.jsm

Comment 3

[:Gijs (he/him)]

(In reply to Kris Maglione [:kmag] from comment #2)
> Except, of course... :(
> 
> https://dxr.mozilla.org/addons/search?q=HiddenFrame.jsm
> 
> And this is a bit worrisome...
> 
> https://dxr.mozilla.org/addons/source/addons/751348/test/omni/modules/
> SelfSupportBackend.jsm

Huh, that looks like it's just a copy of the SelfSupportBackend.jsm we ship. https://dxr.mozilla.org/addons/source/addons/751348/install.rdf doesn't really help elucidate what kind of add-on this is. :-\

Comment 4

[:Gijs (he/him)]

The only other add-on hit seems to be https://addons.mozilla.org/en-US/firefox/addon/super-start/ , which also isn't e10s-compatible... So I think we should just move it.

Comment 5

[Kris Maglione [:kmag]]

Yeah, agreed

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1356030 - move HiddenFrame.jsm to toolkit,

Review commit: https://reviewboard.mozilla.org/r/129920/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129920/

Comment 7

[:Gijs (he/him)]

This presumably also explains the test failure on android which I, in my ignorance, just disabled :-\

Not part of the patch as submitted for review yet, but here's a trypush to check it:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=585497447efd6d2a6076f98b3bf4e4a2e60096c9

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs from comment #7)
> This presumably also explains the test failure on android which I, in my
> ignorance, just disabled :-\
> 
> Not part of the patch as submitted for review yet, but here's a trypush to
> check it:
> 
> remote:  
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=585497447efd6d2a6076f98b3bf4e4a2e60096c9

It's green, so updating the patch to include this. :-)

Comment 9

[:Gijs (he/him)]

Comment on attachment 8857889 [details]
Bug 1356030 - move HiddenFrame.jsm to toolkit,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129920/diff/1-2/

Comment 10

[Kris Maglione [:kmag]]

Comment on attachment 8857889 [details]
Bug 1356030 - move HiddenFrame.jsm to toolkit,

https://reviewboard.mozilla.org/r/129920/#review132686

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b59c6604cafa
move HiddenFrame.jsm to toolkit, r=kmag

Comment 12

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b59c6604cafa