1356033 - chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

Description

[Florian Quèze [:florian]]

The three following SVG files are shipped in browser/ but are only used in devtools/, they should be moved.

"chrome://browser/content/gcli_sec_bad.svg"
"chrome://browser/content/gcli_sec_good.svg"
"chrome://browser/content/gcli_sec_moderate.svg"

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1356033 - chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools

This is easy to test:

Green tick marks (gcli_sec_good.svg) and Red Crosses (gcli_sec_bad.svg):
1. Go to https://csp-evaluator.withgoogle.com/
2. Shift+F2
3. security csp

I couldn't find a way to show the Orange Minus (gcli_sec_moderate.svg) but the path is changed in line with the other images and I did test it programatically so it will be fine.

Review commit: https://reviewboard.mozilla.org/r/136218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136218/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8864541 [details]
Bug 1356033 - chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools

https://reviewboard.mozilla.org/r/136218/#review139390

LGTM, thanks for adding the testing instructions!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2febf984044a
chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools r=jdescottes

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage due to now unused pattern "gcli*" in browser/base/content/moz.build:

https://hg.mozilla.org/integration/autoland/rev/410b3a625af745cf3284b4c1b0ef45b247d68738

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2febf984044a9332f7f66b000b59d2dcee0b5515&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
> TEST-UNEXPECTED-FAIL | /home/worker/workspace/build/src/config/tests/test_mozbuild_reading.py | TestMozbuildReading.test_orphan_file_patterns, line 105: The pattern 'gcli*' in a Files() entry in '/home/worker/workspace/build/src/browser/base/content/moz.build' corresponds to no files in the tree.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8864541 [details]
Bug 1356033 - chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136218/diff/1-2/

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Sorry, I had searched for the filenames but didn't consider gcli*.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8e67ddc6f34
chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools r=jdescottes

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c8e67ddc6f34