Closed Bug 1356033 Opened 3 years ago Closed 3 years ago

chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: miker)

References

Details

Attachments

(1 file)

The three following SVG files are shipped in browser/ but are only used in devtools/, they should be moved.

"chrome://browser/content/gcli_sec_bad.svg"
"chrome://browser/content/gcli_sec_good.svg"
"chrome://browser/content/gcli_sec_moderate.svg"
Component: Developer Tools → Developer Tools: Graphic Commandline and Toolbar
Assignee: nobody → mratcliffe
Priority: -- → P2
Comment on attachment 8864541 [details]
Bug 1356033 - chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools

https://reviewboard.mozilla.org/r/136218/#review139390

LGTM, thanks for adding the testing instructions!
Attachment #8864541 - Flags: review?(jdescottes) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2febf984044a
chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools r=jdescottes
Backed out for bustage due to now unused pattern "gcli*" in browser/base/content/moz.build:

https://hg.mozilla.org/integration/autoland/rev/410b3a625af745cf3284b4c1b0ef45b247d68738

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2febf984044a9332f7f66b000b59d2dcee0b5515&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
> TEST-UNEXPECTED-FAIL | /home/worker/workspace/build/src/config/tests/test_mozbuild_reading.py | TestMozbuildReading.test_orphan_file_patterns, line 105: The pattern 'gcli*' in a Files() entry in '/home/worker/workspace/build/src/browser/base/content/moz.build' corresponds to no files in the tree.
Flags: needinfo?(mratcliffe)
Sorry, I had searched for the filenames but didn't consider gcli*.
Flags: needinfo?(mratcliffe)
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c8e67ddc6f34
chrome://browser/content/gcli_sec_{bad,good,moderate}.svg should be moved to devtools r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/c8e67ddc6f34
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.