1356074 - stylo: More media query stuff.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

I plan to:

 * Investigate the clone failures in test_media_queries.html.
 * Use Servo for matchMedia.
 * Implement parsing for keyword media queries.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1356074: Implement keyword-valued media queries.

Review commit: https://reviewboard.mozilla.org/r/129830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129830/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8857817 [details]
Bug 1356074: Implement keyword-valued media queries.

https://reviewboard.mozilla.org/r/129830/#review132450

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1356074: Use Servo for window.matchMedia and MediaQueryList.

Review commit: https://reviewboard.mozilla.org/r/130128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130128/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1356074: Update test expectations.

Review commit: https://reviewboard.mozilla.org/r/130130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130130/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8857817 [details]
Bug 1356074: Implement keyword-valued media queries.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129830/diff/1-2/

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8858191 [details]
Bug 1356074: Use Servo for window.matchMedia and MediaQueryList.

https://reviewboard.mozilla.org/r/130128/#review132772

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8858192 [details]
Bug 1356074: Update test expectations.

https://reviewboard.mozilla.org/r/130130/#review132778

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/986fb667ee10
Implement keyword-valued media queries. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b137d947dbba
Use Servo for window.matchMedia and MediaQueryList. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/2b1d378dc8b7
Update test expectations. r=heycam

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/986fb667ee10
https://hg.mozilla.org/mozilla-central/rev/b137d947dbba
https://hg.mozilla.org/mozilla-central/rev/2b1d378dc8b7