Closed Bug 1356088 Opened 3 years ago Closed 3 years ago

Fix ImageKey removals of ExternalImages

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1345142 moved ImageKeys removals of ExternalImages to client side. But there seems to be several cases that the keys are not removed.
Assignee: nobody → sotaro.ikeda.g
Depends on: 1345142
Blocks: 1355702
Attachment #8857760 - Attachment is obsolete: true
Blocks: 1356130
Attachment #8857774 - Flags: review?(jmuizelaar)
Comment on attachment 8857774 [details] [diff] [review]
patch - Fix ImageKey removals of ExternalImages

Review of attachment 8857774 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +698,5 @@
>      mApi->ClearRootDisplayList(wr::NewEpoch(mWrEpoch), mPipelineId);
> +    for (auto iter = mActiveKeys.Iter(); !iter.Done(); iter.Next()) {
> +      mKeysToDelete.push_back(iter.Data());
> +      iter.Remove();
> +    }

This seems fine to do for now, but I wonder if it's the right strategy in the long term. The client probably needs to know if the keys are going away behind it's back.
Attachment #8857774 - Flags: review?(jmuizelaar) → review+
It is necessary for now to avoid leaks. But it might better to be changed in future.
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/72fdb3d33943
Fix ImageKey removals of ExternalImages r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.