Allow software backed compositor process (behind a preference)

RESOLVED FIXED in Firefox 54

Status

()

Core
Graphics
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: milan, Assigned: milan)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed, firefox55 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Right now we insist on an accelerated compositor when deciding if we want a compositor process or not.  Behind a preference, allow the software backend and compositor process combination.
http://searchfox.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp#1577
We do have layers.gpu-process.force-enabled preference, but that is a bit too strong.
Comment hidden (mozreview-request)
Comment on attachment 8857756 [details]
Bug 1356091: Allow the compositor process with the software compositor.

https://reviewboard.mozilla.org/r/129724/#review132354
Attachment #8857756 - Flags: review?(dvander) → review+

Comment 5

4 months ago
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb9c72e4a639
Allow the compositor process with the software compositor. r=dvander
Comment on attachment 8857756 [details]
Bug 1356091: Allow the compositor process with the software compositor.

Approval Request Comment
This introduces a preference, and allows software compositor in the compositor process when that preference is set - which it isn't by default.  So, the change as such is a no-op and thus of very low (zero :) risk.
Why do we want it?  There are some indications that there may be performance improvements with the compositor process (bug 1334655), not just the stability when it comes to the drivers.  If this is the case, well, things are good.

We'd like to be able to run some telemetry experiments with 54 on aurora/beta, which is what this change/preference would allow us to do.
Attachment #8857756 - Flags: approval-mozilla-aurora?
Assignee: nobody → milan
Whiteboard: [gfx-noted]

Comment 7

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cb9c72e4a639
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
It'd be interesting to see if this nudges Talos in one direction or another on Windows non-accelerated backend(s)
(In reply to Milan Sreckovic [:milan] from comment #8)
> It'd be interesting to see if this nudges Talos in one direction or another
> on Windows non-accelerated backend(s)

Uhm, of course it shouldn't, because it is off by default.
Blocks: 1356448

Updated

4 months ago
status-firefox54: --- → affected
Comment on attachment 8857756 [details]
Bug 1356091: Allow the compositor process with the software compositor.

There might be performance improvement here. Aurora54+.
Attachment #8857756 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 11

4 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/fc6add581f88
status-firefox54: affected → fixed
Blocks: 1367246
You need to log in before you can comment on or make changes to this bug.