1356125 - stylo: support all shorthand

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: stylo: Generate eCSSPropertyID_all as a const rather than an enum value.

Review commit: https://reviewboard.mozilla.org/r/129748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129748/

Comment 2

[Cameron McCormack (:heycam)]

Attachment: style: Support the all shorthand.

Review commit: https://reviewboard.mozilla.org/r/129750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129750/

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1356125 - stylo: Update test expectations.

Review commit: https://reviewboard.mozilla.org/r/129752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129752/

Comment 4

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5088a825c44bd3c877f1d3e7ec7817143671c176

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8857778 [details]
stylo: Generate eCSSPropertyID_all as a const rather than an enum value.

https://reviewboard.mozilla.org/r/129748/#review132384

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8857779 [details]
style: Support the all shorthand.

https://reviewboard.mozilla.org/r/129750/#review132386

::: servo/components/style/properties/properties.mako.rs:169
(Diff revision 1)
>      <%include file="/shorthand/padding.mako.rs" />
>      <%include file="/shorthand/position.mako.rs" />
>      <%include file="/shorthand/inherited_svg.mako.rs" />
>      <%include file="/shorthand/text.mako.rs" />
> +
> +    <% components_of_all_shorthand = [p.name for p in data.longhands if p.name not in ['direction', 'unicode-bidi']] %>

Can you leave a `TODO` comment here regarding we might be able to cascade this more efficiently by not expanding to all longhands?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8857780 [details]
Bug 1356125 - stylo: Update test expectations.

https://reviewboard.mozilla.org/r/129752/#review132390

Comment 8

[Cameron McCormack (:heycam)]

https://github.com/servo/servo/pull/16413

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8857780 [details]
Bug 1356125 - stylo: Update test expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129752/diff/1-2/

Comment 10

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=134d96b7f17962aef9e92499ac80b2cfab22fe93

Comment 11

[Cameron McCormack (:heycam)]

Comment on attachment 8857780 [details]
Bug 1356125 - stylo: Update test expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129752/diff/2-3/

Comment 12

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a200f93ade7c -d a8a257ba1903: rebasing 389952:a200f93ade7c "Bug 1356125 - stylo: Update test expectations. r=emilio" (tip)
merging layout/style/test/stylo-failures.md
warning: conflicts while merging layout/style/test/stylo-failures.md! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f757c8626d1
stylo: Update test expectations. r=emilio

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1f757c8626d1