Closed Bug 1356126 Opened 7 years ago Closed 7 years ago

Move column react component to separate files

Categories

(DevTools :: Netmonitor, enhancement, P1)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Iteration:
55.3 - Apr 17
Tracking Status
firefox55 --- fixed

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [netmonitor])

Attachments

(1 file)

Refactor request-list-item column react components to separate files.

We could do several treatments in followup bug (turn div to table, reduce elements...etc)
Flags: qe-verify-
Whiteboard: [netmonitor][triage]
Comment on attachment 8857784 [details]
Bug 1356126 - Move column react component to separate files;

https://reviewboard.mozilla.org/r/129764/#review132378

Nice work Fred! Do you think we can also solve bug 1355803 within this bug?
No, we use a lot `shouldComponentUpdate` to make sure the frequent update items are not updated when the data is the same, and stateless function component doesn't provide the equivalent feature. 

So at this time I'd rather keep using stateful components.
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [netmonitor][triage] → [netmonitor]
Comment on attachment 8857784 [details]
Bug 1356126 - Move column react component to separate files;

https://reviewboard.mozilla.org/r/129764/#review132392

LGTM.
Attachment #8857784 - Flags: review?(rchien) → review+
It will needs rebasing with bug 1345489
thanks, I'll rebase after bug 1345489 is landed to central
Depends on: 1345489
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/996ef5cded0f
Move column react component to separate files;r=rickychien
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/996ef5cded0f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.3 - Apr 17
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: