Closed
Bug 1356126
Opened 7 years ago
Closed 7 years ago
Move column react component to separate files
Categories
(DevTools :: Netmonitor, enhancement, P1)
DevTools
Netmonitor
Tracking
(firefox55 fixed)
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: gasolin, Assigned: gasolin)
References
Details
(Whiteboard: [netmonitor])
Attachments
(1 file)
Refactor request-list-item column react components to separate files. We could do several treatments in followup bug (turn div to table, reduce elements...etc)
Updated•7 years ago
|
Flags: qe-verify-
Whiteboard: [netmonitor][triage]
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8857784 [details] Bug 1356126 - Move column react component to separate files; https://reviewboard.mozilla.org/r/129764/#review132378 Nice work Fred! Do you think we can also solve bug 1355803 within this bug?
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
No, we use a lot `shouldComponentUpdate` to make sure the frequent update items are not updated when the data is the same, and stateless function component doesn't provide the equivalent feature. So at this time I'd rather keep using stateful components.
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [netmonitor][triage] → [netmonitor]
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8857784 [details] Bug 1356126 - Move column react component to separate files; https://reviewboard.mozilla.org/r/129764/#review132392 LGTM.
Attachment #8857784 -
Flags: review?(rchien) → review+
Comment 6•7 years ago
|
||
It will needs rebasing with bug 1345489
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
thanks, I'll rebase after bug 1345489 is landed to central
Depends on: 1345489
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 10•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/996ef5cded0f Move column react component to separate files;r=rickychien
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/996ef5cded0f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•7 years ago
|
Blocks: netmonitor-phaseII
Iteration: --- → 55.3 - Apr 17
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•