1356129 - Remove some old UI migration steps

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1280999 +++

Comment 1

[Dão Gottwald [:dao]]

This is needed to avoid bug 1352069 comment 14.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1356129 - Remove another batch of old UI migration steps.

Review commit: https://reviewboard.mozilla.org/r/129768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129768/

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8857786 [details]
Bug 1356129 - Remove another batch of old UI migration steps.

https://reviewboard.mozilla.org/r/129768/#review132464

I didn't know we had a check for functions complexity, which test is doing that check? I'd like to know more about it.

::: browser/components/nsBrowserGlue.js:1594
(Diff revision 1)
>        Services.prefs.clearUserPref("dom.disable_window_move_resize");
>        Services.prefs.clearUserPref("dom.disable_window_flip");
>        Services.prefs.clearUserPref("dom.event.contextmenu.enabled");
>        Services.prefs.clearUserPref("javascript.enabled");
>        Services.prefs.clearUserPref("permissions.default.image");
>      }

probably you could also remove this (Firefox 23)

The first migration step would then be 14, that is Firefox 25.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [::mak] from comment #3)
> Comment on attachment 8857786 [details]
> Bug 1356129 - Remove another batch of old UI migration steps.
> 
> https://reviewboard.mozilla.org/r/129768/#review132464
> 
> I didn't know we had a check for functions complexity, which test is doing
> that check? I'd like to know more about it.

I have no idea, it's probably very new.

> ::: browser/components/nsBrowserGlue.js:1594
> (Diff revision 1)
> >        Services.prefs.clearUserPref("dom.disable_window_move_resize");
> >        Services.prefs.clearUserPref("dom.disable_window_flip");
> >        Services.prefs.clearUserPref("dom.event.contextmenu.enabled");
> >        Services.prefs.clearUserPref("javascript.enabled");
> >        Services.prefs.clearUserPref("permissions.default.image");
> >      }
> 
> probably you could also remove this (Firefox 23)

Okay.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8857786 [details]
Bug 1356129 - Remove another batch of old UI migration steps.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129768/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47c1ac2f3f47
Remove another batch of old UI migration steps. r=mak

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Marco Bonardo [::mak] from comment #3)
> Comment on attachment 8857786 [details]
> Bug 1356129 - Remove another batch of old UI migration steps.
> 
> https://reviewboard.mozilla.org/r/129768/#review132464
> 
> I didn't know we had a check for functions complexity, which test is doing
> that check? I'd like to know more about it.

It's an eslint rule. See http://eslint.org/docs/rules/complexity and https://bugzilla.mozilla.org/show_bug.cgi?id=1347884

Comment 8

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> (In reply to Marco Bonardo [::mak] from comment #3)
> > Comment on attachment 8857786 [details]
> > Bug 1356129 - Remove another batch of old UI migration steps.
> > 
> > https://reviewboard.mozilla.org/r/129768/#review132464
> > 
> > I didn't know we had a check for functions complexity, which test is doing
> > that check? I'd like to know more about it.
> 
> It's an eslint rule. See http://eslint.org/docs/rules/complexity and
> https://bugzilla.mozilla.org/show_bug.cgi?id=1347884

I think that's a bit problematic. Commented in bug 1326071 comment 3.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47c1ac2f3f47