1356170 - Firefox might display incomplete date/time picker on some devices

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Sergiu Logigan [:sergiu]]

Attachment: roblox.txt

Environment:
Samsung Galaxy Note 4 (Android 5.0.1)
Firefox 52.0 Release (Mobile)


Steps to reproduce:
1. Navigate to https://m.roblox.com/Account/SignUp
2. Tap the Birthday field.

Expected results:
A date picker is displayed.

Actual results:
Firefox crashes.

Notes:
1. Reprodibility rate: 100%
2. The issue is not reproducible on a Nexus 5 device.
3. The issue is also reproducible in Nightly 55.0a1 (2017-04-12) (Mobile), but with a different Actual result: An incomplete date/time picker is displayed.
4. Logs attached.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Seems to be dup of Bug 1339884, but Bug 1339884 says it only affects Android API level 19 and below (i.e. Android 4.x).
Can we confirm whether the patches in Bug 1339884 can fix this?

Comment 2

[Jan Henning [:JanH]]

(In reply to Jessica Jong [:jessica] from comment #1)
> Seems to be dup of Bug 1339884, but Bug 1339884 says it only affects Android
> API level 19 and below (i.e. Android 4.x).
> Can we confirm whether the patches in Bug 1339884 can fix this?

See my comment on bug 1339884 - apparently we were crashing on Android 5.x+ as well, albeit with
- a different crash signature (which is why I didn't notice it)
- under different circumstances (for me, the page from bug 1339884 only crashed on a 4.1.2 device)

According to
(In reply to Sergiu from comment #0)
> 3. The issue is also reproducible in Nightly 55.0a1 (2017-04-12) (Mobile),
> but with a different Actual result: An incomplete date/time picker is
> displayed.

we no longer crash, so I suggest making this bug about fixing the "incomplete date/time picker".

Comment 3

[Jessica Jong [:jessica] (inactive)]

(In reply to Jan Henning [:JanH] from comment #2)
> (In reply to Jessica Jong [:jessica] from comment #1)
> > Seems to be dup of Bug 1339884, but Bug 1339884 says it only affects Android
> > API level 19 and below (i.e. Android 4.x).
> > Can we confirm whether the patches in Bug 1339884 can fix this?
> 
> See my comment on bug 1339884 - apparently we were crashing on Android 5.x+
> as well, albeit with
> - a different crash signature (which is why I didn't notice it)
> - under different circumstances (for me, the page from bug 1339884 only
> crashed on a 4.1.2 device)
> 
> According to
> (In reply to Sergiu from comment #0)
> > 3. The issue is also reproducible in Nightly 55.0a1 (2017-04-12) (Mobile),
> > but with a different Actual result: An incomplete date/time picker is
> > displayed.
> 
> we no longer crash, so I suggest making this bug about fixing the
> "incomplete date/time picker".

Oh right, thanks for point it out. But what does "incomplete date/time picker" means? Can reporter attach a screenshot?
Maybe Wesley can help here.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Sergiu could you attach a screenshot or any further information?
I don't have a android (below SDK19) handy.

Comment 5

[Sergiu Logigan [:sergiu]]

Attachment: screenshot.jpg

Hello, Here's a screenshot taken from the Samsung Galaxy Note 4 (Android 5.0.1) running Nightly 55.0a1 (2017-04-13) (Mobile)

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage] 
P1 as this is function broken

Comment 7

[Andrew Overholt [:overholt]]

Where did we end up on this one?

Comment 8

[Andrew Overholt [:overholt]]

Is there a better component for Fennec-specific date/time issues?

Comment 9

[Jessica Jong [:jessica] (inactive)]

I didn't track this one anymore since it looks like a native picker issue. :)
Wesley, is there a better component for this or do you know anyone who can help? Thanks.

Comment 10

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

So far as I know there are not so many component. 
This bug is P1 so it's should be on Fennec team's radar.

Comment 11

[Wesly Huang (EPM)]

Max, maybe we can have a quick check before further looking into it? (truly a native picker issue?) Thanks.

(In reply to Jessica Jong [:jessica] from comment #9)
> I didn't track this one anymore since it looks like a native picker issue. :)

Comment 12

[Jan Henning [:JanH]]

The CalendarView is native, but it's wrapped and used within our own DateTimePicker (https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/widget/DateTimePicker.java).

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] This sucks: P1 and an action item to confirm because I think not supporting a date picker can be a critical issue.

Comment 14

[:sdaswani]

Mike, I agree this should be looked into. Per https://bugzilla.mozilla.org/show_bug.cgi?id=1318046, let me figure out who should work on this.

Comment 15

[:sdaswani]

Removing NI as this may be tracked here: https://bugzilla.mozilla.org/buglist.cgi?priority=P1&emailreporter1=1&resolution=---&emailtype1=notequals&chfieldto=Now&query_format=advanced&chfield=%5BBug%20creation%5D&chfieldfrom=2016-06-01&email1=intermittent-bug-filer%40mozilla.bugs&component=Activity%20Stream&component=Awesomescreen&component=Custom%20Tabs&component=Download%20Manager&component=Favicon%20Handling&component=First%20Run&component=General&component=Locale%20switching%20and%20selection&component=Logins%2C%20Passwords%20and%20Form%20Fill&component=Metrics&component=Overlays&component=Profile%20Handling&component=Reader%20View&component=Screencasting&component=Search%20Activity&component=Settings%20and%20Preferences&component=Text%20Selection&product=Firefox%20for%20Android&list_id=13989016

Comment 16

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 17

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.