If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix GetNextExternalImageId()

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 months ago
GetNextExternalImageId() is implemented as temporal way. It should be addressed.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/wr/WebRenderBridgeChild.cpp#112
(Assignee)

Updated

5 months ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

5 months ago
Created attachment 8857883 [details] [diff] [review]
patch - Fix GetNextExternalImageId()
(Assignee)

Comment 2

5 months ago
attachment 8857883 [details] [diff] [review] moved actual external image id allocation to CompositorBridgeChild.

And GetNextExternalImageId() is also added to ImageBridgeChild. It is going to be used to allocate external image ids to TextureClients/TextureHosts.
(Assignee)

Comment 3

5 months ago
Since Bug 1343764, host sides already allocate external image ids to WebRenderTextureHosts. There is some inconsistency between client and host side, this bug is a first step to address the inconsistency.
(Assignee)

Comment 4

5 months ago
Created attachment 8857890 [details] [diff] [review]
patch - Fix GetNextExternalImageId()
Attachment #8857883 - Attachment is obsolete: true
(Assignee)

Comment 5

5 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=534d43d338be63bb0be2c0bc44462a28447c433f
(Assignee)

Updated

5 months ago
Attachment #8857890 - Flags: review?(jmuizelaar)
Attachment #8857890 - Flags: review?(jmuizelaar) → review+

Comment 6

5 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/de44ef87432b
Fix GetNextExternalImageId() r=jrmuizel
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/de44ef87432b3ca50dff0fc3c4a76b2d539d1ac8
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.