Closed Bug 1356190 Opened 3 years ago Closed 3 years ago

Fix GetNextExternalImageId()

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file, 1 obsolete file)

GetNextExternalImageId() is implemented as temporal way. It should be addressed.

https://dxr.mozilla.org/mozilla-central/source/gfx/layers/wr/WebRenderBridgeChild.cpp#112
Assignee: nobody → sotaro.ikeda.g
attachment 8857883 [details] [diff] [review] moved actual external image id allocation to CompositorBridgeChild.

And GetNextExternalImageId() is also added to ImageBridgeChild. It is going to be used to allocate external image ids to TextureClients/TextureHosts.
Since Bug 1343764, host sides already allocate external image ids to WebRenderTextureHosts. There is some inconsistency between client and host side, this bug is a first step to address the inconsistency.
Attachment #8857883 - Attachment is obsolete: true
Attachment #8857890 - Flags: review?(jmuizelaar)
Attachment #8857890 - Flags: review?(jmuizelaar) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/de44ef87432b
Fix GetNextExternalImageId() r=jrmuizel
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.