Closed Bug 1356191 Opened 3 years ago Closed 3 years ago

Improve platform detection for gyp

Categories

(NSS :: Build, enhancement)

3.31
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: franziskus, Assigned: franziskus)

References

Details

Attachments

(1 file)

We can do a little better with some platform detection in gyp.
The attached patch moves some platform detection to config.gypi so that we can use that information in all parts not only freebl. It enables uint128 support on aarch64 and makes gyp usable of armhf.
Attachment #8857880 - Flags: review?(ted)
Attachment #8857880 - Flags: review?(martin.thomson)
Comment on attachment 8857880 [details] [diff] [review]
gyp-platform.patch

Review of attachment 8857880 [details] [diff] [review]:
-----------------------------------------------------------------

Not entirely happy that you are bundling two changes here, but both look sound.
Attachment #8857880 - Flags: review?(martin.thomson) → review+
https://hg.mozilla.org/projects/nss/rev/7e99f75f196d868e21beb8956257e2fa199d6b6e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.32
Comment on attachment 8857880 [details] [diff] [review]
gyp-platform.patch

Review of attachment 8857880 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/freebl/freebl.gyp
@@ +173,5 @@
>          'msvs_settings': {
>            'VCCLCompilerTool': {
>              #TODO: -Ox optimize flags
>              'PreprocessorDefinitions': [
>                'NSS_USE_64',

You moved `NSS_USE_64` into config.gypi, so you should be able to remove it here (and in the !win block below).
Attachment #8857880 - Flags: review?(ted) → review+
You need to log in before you can comment on or make changes to this bug.