1356193 - GetChannelResultPrincipal shouldn't call the result of GetSecurityMode securityFlags

Status: RESOLVED FIXED

(Core :: Security: CAPS, enhancement)

Description

[:Gijs (he/him)]

>    nsSecurityFlags securityFlags = loadInfo->GetSecurityMode();
>    // The data: inheritance flags should only apply to the initial load,
>    // not to loads that it might have redirected to.
>    if (loadInfo->RedirectChain().IsEmpty() &&
>        (securityFlags == nsILoadInfo::SEC_REQUIRE_SAME_ORIGIN_DATA_INHERITS ||
>         securityFlags == nsILoadInfo::SEC_ALLOW_CROSS_ORIGIN_DATA_INHERITS ||
>         securityFlags == nsILoadInfo::SEC_REQUIRE_CORS_DATA_INHERITS)) {

This code is confusing because flags (including the loadinfo flags) are normally combinatory, but the securitymode isn't - it will have only one of these flags. We should rename securityFlags to securityMode because that would make it less confusing.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1356193 - rename securityFlags local variable for code clarity reasons,

Review commit: https://reviewboard.mozilla.org/r/129912/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129912/

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8857886 [details]
Bug 1356193 - rename securityFlags local variable for code clarity reasons,

https://reviewboard.mozilla.org/r/129912/#review132482

thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419b0dc9e1a6
rename securityFlags local variable for code clarity reasons, r=ckerschb

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/419b0dc9e1a6