Uplift bug 1349883 and 1346235 to aurora(54)

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jhlin, Assigned: jhlin)

Tracking

54 Branch
Points:
---

Firefox Tracking Flags

(firefox54 fixed, firefox55 unaffected)

Details

Attachments

(8 attachments)

(Assignee)

Description

2 years ago
Created attachment 8857900 [details] [diff] [review]
part 1: translate native error to Java exception

Bug 1349883 addresses the frozen video image issues (1348085 and 1348864) and is dependent on patches in bug 1346235.
(Assignee)

Comment 1

2 years ago
Created attachment 8857901 [details] [diff] [review]
part 2: translate memory error to I/O failure
(Assignee)

Comment 2

2 years ago
Created attachment 8857902 [details] [diff] [review]
part 3: forward shared memory allocation error to peer process
(Assignee)

Comment 3

2 years ago
Created attachment 8857903 [details] [diff] [review]
part 4: recycle unpopulated input samples
(Assignee)

Comment 4

2 years ago
Created attachment 8857904 [details] [diff] [review]
part 5: combine output buffer index and sample records
(Assignee)

Comment 5

2 years ago
Created attachment 8857905 [details] [diff] [review]
part 6: reveal more input buffer status to callbacks
(Assignee)

Comment 6

2 years ago
Created attachment 8857906 [details] [diff] [review]
part 7: resolve decode promise according to buffer status
(Assignee)

Comment 7

2 years ago
Created attachment 8857907 [details] [diff] [review]
part 8: strengthen precondition of ReturnDecodedData()
(Assignee)

Comment 8

2 years ago
This is a big changeset, but alternative, rollback to bug 1319987, is risky too: that month old version haven't been tested so it's hard to say what side effect/regression it'll have.
(Assignee)

Comment 9

2 years ago
Comment on attachment 8857900 [details] [diff] [review]
part 1: translate native error to Java exception

Approval Request Comment
[Feature/Bug causing the regression]: bug 1319987
[User impact if declined]: frozen video image
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: yes. See STR in bug 1348864.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: yes
[Why is the change risky/not risky?]: it changes the OOP decoding buffer handling code significantly
[String changes made/needed]: none
Attachment #8857900 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 10

2 years ago
Please uplift all 8 patches after approval, thanks!
Get 54 RM's attention.
Flags: needinfo?(gchang)

Updated

2 years ago
status-firefox54: --- → affected
Flags: needinfo?(gchang)
Comment on attachment 8857900 [details] [diff] [review]
part 1: translate native error to Java exception

After discussing with dev, we need to uplift these patches to aurora to fix the critical regression of video playback. Aurora54+.
Attachment #8857900 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee: nobody → jolin
status-firefox55: --- → unaffected
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.