1356213 - Static analysis and valgrind builds busted with artifact mode

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When pushing to try with artifact mode enabled both the static analysis and valgrind builds are failing:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=960afa27408012ce19363a7063624849130bdccd

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1356213 - Prevent valgrind and static analysis builds from being replaced with an artifact build.

Review commit: https://reviewboard.mozilla.org/r/130398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130398/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8858430 [details]
Bug 1356213 - Prevent valgrind and static analysis builds from being replaced with an artifact build.

https://reviewboard.mozilla.org/r/130398/#review133090

Yep yep.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f60b0bcc75b5
Prevent valgrind and static analysis builds from being replaced with an artifact build. r=nalexander

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f60b0bcc75b5

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When looking at the landed patch I can only see fixes for Linux, but not MacOS and Windows which at least also have static analysis builds. Chris, should I file a follow-up bug, or do you want to re-use this one?

Comment 6

[Chris Manchester (limited bugmail, email directly)]

We need to audit variant builds and make sure this isn't happening anywhere. I'll file something.