Closed Bug 1356278 Opened 7 years ago Closed 7 years ago

In-product links still not working in german (after fixes were pushed to production)

Categories

(support.mozilla.org - Lithium :: General, defect)

Product:
support.mozilla.org - Lithium
Component:
General
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: philipp, Unassigned)

References

Details

Attachments

(1 file)

Localized links redirecting to SUMO Eng page.txt
81.28 KB, text/plain
Details 
inproduct links still seem to be not working for me with a german build of firefox (tested with 45 esr, release, 53.0b and 54.0a2).

links i've tested:
* (?) on top right of about:preferences -> https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/prefs-main
* "Weitere Informationen..." button on https://expired.badssl.com/ -> https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/time-errors
* menu bar > Hilfe > Tastenkobinationen -> https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/keyboard-shortcuts
* "Weitere Informationen" on top of about:plugins -> https://support.mozilla.org/1/firefox/53.0/WINNT/de/npapi

all these links end up on the english sumo homepage at https://support.mozilla.org/t5/Mozilla-Support-English/ct-p/Mozilla-EN
thanks for testing :philipp, i am pretty sure ESR is broken, not sure we plan on fixing it. 
However as far as I can tell, it should work in FF53 and FF54

Could we please get QA to look at this :elan?
Flags: needinfo?(elancaster)
(In reply to Roland Tanglao :rolandtanglao from comment #1)
> thanks for testing :philipp, i am pretty sure ESR is broken, not sure we
> plan on fixing it. 
> However as far as I can tell, it should work in FF53 and FF54
> 
> Could we please get QA to look at this :elan?

Confirming I'll have SV test links (not content) for the German locales for 53 and 54.
disclaimer: i only tested the "de"-locale and don't want to make the scope of this bug too small. changing the urls mentioned above to other locales like fr, nl, ja etc doesn't seem to work either...
SV just confirmed: these are not fixed. de all points to en-us. Is there more testing needed at this point :roland?
Flags: needinfo?(elancaster) → needinfo?(rtanglao)
unfortunately i think we need to test at least a few more locales:
i would suggest:

0. french (or other roman with accents)
1. one cyrillic i.e. non roman, eastern european e.g. russian
2. one RTL (not sure what locales are RTL but is it hebrew? or some such? i am sure SV will know)
3. one of japanese or simplified chinese
4. brazilian or portuguese portuguese

to make sure we know the full extent of the breakage

does that sound reasonable :elan?
Flags: needinfo?(rtanglao) → needinfo?(elancaster)
and to be clear the fix is to:
change the links

FROM:
old style: 
"stub/1/OS/version/etc"

TO
new style:
stub-<locale>
See Also: → 1337562
See Also: → 1324426
(In reply to Roland Tanglao :rolandtanglao from comment #5)
> unfortunately i think we need to test at least a few more locales:
> i would suggest:
> 
> 0. french (or other roman with accents)
> 1. one cyrillic i.e. non roman, eastern european e.g. russian
> 2. one RTL (not sure what locales are RTL but is it hebrew? or some such? i
> am sure SV will know)
> 3. one of japanese or simplified chinese
> 4. brazilian or portuguese portuguese


Tested following localized links: 

Redirecting to the expected page 
https://support.mozilla.org/screenshare-safety-ru
redirected to: https://support.mozilla.org/t5/-/-/ta-p/32618

https://support.mozilla.org/screenshare-safety-fr
redirected to: https://support.mozilla.org/t5/-/-/ta-p/32197

https://support.mozilla.org/screenshare-safety-pt-BR
redirected to: https://support.mozilla.org/t5/-/-/ta-p/32703

https://support.mozilla.org/screenshare-safety-zh-CN
redirected to: https://support.mozilla.org/t5/-/-/ta-p/32672



Redirecting to English page

https://support.mozilla.org/screenshare-safety-ko
redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616


https://support.mozilla.org/screenshare-safety-de
redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616


https://support.mozilla.org/screenshare-safety-ar
redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616


https://support.mozilla.org/screenshare-safety-hr
redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616



For the following 3 articles all localized links are ending up redirecting to the English SUMO Home page.

- Options window - Advanced panel
- Options window - Content panel
- Page Info window
The attachment is added in previous comment. Please look at the attachment.
(In reply to Damira from comment #8)

I am confused, :damira is the following testing done:

A) manually from the product? i.e. open the appropriate localized version firefox for windows 
(e.g. firefox for windows localized german build if you are testing german in-product links), 
and then try the in-product links from the Firefox user interface

B) by typing the link into the browser

Please make sure you are doing A). It appears you did B) unless I am missing something?!?

Cheers!

...Roland


> 
> Tested following localized links: 
> 
> Redirecting to the expected page 
> https://support.mozilla.org/screenshare-safety-ru
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/32618
> 
> https://support.mozilla.org/screenshare-safety-fr
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/32197
> 
> https://support.mozilla.org/screenshare-safety-pt-BR
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/32703
> 
> https://support.mozilla.org/screenshare-safety-zh-CN
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/32672
> 
> 
> 
> Redirecting to English page
> 
> https://support.mozilla.org/screenshare-safety-ko
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616
> 
> 
> https://support.mozilla.org/screenshare-safety-de
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616
> 
> 
> https://support.mozilla.org/screenshare-safety-ar
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616
> 
> 
> https://support.mozilla.org/screenshare-safety-hr
> redirected to: https://support.mozilla.org/t5/-/-/ta-p/29616
> 
> 
> 
> For the following 3 articles all localized links are ending up redirecting
> to the English SUMO Home page.
> 
> - Options window - Advanced panel
> - Options window - Content panel
> - Page Info window
> The attachment is added in previous comment. Please look at the attachment.
Flags: needinfo?(dakhmedova)
(In reply to Roland Tanglao :rolandtanglao from comment #9)
> (In reply to Damira from comment #8)
> 
> I am confused, :damira is the following testing done:
> 
> A) manually from the product? i.e. open the appropriate localized version
> firefox for windows 
> (e.g. firefox for windows localized german build if you are testing german
> in-product links), 
> and then try the in-product links from the Firefox user interface
> 
> B) by typing the link into the browser
> 
> Please make sure you are doing A). It appears you did B) unless I am missing
> something?!?
> 
> Cheers!
> 
> ...Roland
> 

Hi Roland,

I did automated link testing by typing the link into the browser EN-US.
Also I did manually following steps.
 
Steps in Testing:
1-Installed Firefox 53.0b1 on Windows (x64 he)/(x64 hr)/(x64 de)/(x64 ar)/(x64 ru)/ (x64 zh-CN) and EN-US
2-and then tried in-product links from the Firefox user interface
Tested Areas:
Menu -> Help -> Keyboard Shortcuts

Hebrew / Arabic / German / Russian / Chinese  A ll ended up redirecting to 
https://support.mozilla.org/t5/How-To/Keyboard-shortcuts/ta-p/15978
Flags: needinfo?(dakhmedova)
(In reply to Damira from comment #10)
Just my 2c
Does that indicate that after partial testing multiple locale products are failing on what is tested ?
>....
> I did automated link testing by typing the link into the browser EN-US.
> Also I did manually following steps.
>  
> Steps in Testing:
> 1-Installed Firefox 53.0b1 on Windows (x64 he)/(x64 hr)/(x64 de)/(x64
> ar)/(x64 ru)/ (x64 zh-CN) and EN-US

Apparently you tried testing from *Firefox* builds other than en-us
Hopefully using the Windows locales is important and does result in an appropriate locale version of Firefox being installed, but it would be helpful if that could be confirmed when reporting testing results I think. 

Getting a result of https://support.mozilla.org/t5/How-To/Keyboard-shortcuts/ta-p/15978 is in any event not what I think is hoped for, because that is itself a redirect which for me gives https://support.mozilla.org/t5/Basic-Browsing/Keyboard-shortcuts-Perform-common-Firefox-tasks-quickly/ta-p/3866
(In reply to Damira from comment #10)
> I did automated link testing by typing the link into the browser EN-US.
> Also I did manually following steps.
>  
> Steps in Testing:
> 1-Installed Firefox 53.0b1 on Windows (x64 he)/(x64 hr)/(x64 de)/(x64
> ar)/(x64 ru)/ (x64 zh-CN) and EN-US
> 2-and then tried in-product links from the Firefox user interface
> Tested Areas:
> Menu -> Help -> Keyboard Shortcuts
> 
> Hebrew / Arabic / German / Russian / Chinese  A ll ended up redirecting to 
> https://support.mozilla.org/t5/How-To/Keyboard-shortcuts/ta-p/15978

when testing, please make sure that you use new profiles or reset the "intl.accept_languages" pref at least. when "en" is on top of the list in the options > content > languages list, the redirects work - when it's a different language (which it should be on various localized builds) the redirects fail and end up on https://support.mozilla.org/t5/Mozilla-Support-English/ct-p/Mozilla-EN
:John99 - what you describe is expected behavior until we get the permanent fix in place from Lithium. We don't have an ETA on as of right now. 

:philipp - are you asking Damira to re-test with that pref flipped? Is this pref not flipped by default once a localized build is installed?
(In reply to Erin Lancaster [:elan] from comment #13)
> :John99 - what you describe is expected behavior until we get the permanent
> fix in place from Lithium. We don't have an ETA on as of right now. 
> 
> :philipp - are you asking Damira to re-test with that pref flipped? Is this
> pref not flipped by default once a localized build is installed?

:elan: I think :philipp is simply asking Damira to re-test with a localized e.g. German Firefox 53 desktop build with a new *new Firefox profile*. No need to flip the pref. Right :philipp?
Flags: needinfo?(madperson)
yes, that's right! also, since it's so easy to reproduce the problem consistently i'm asking less about running more tests on this, but would rather hope that we could come up with a fix that works.
Flags: needinfo?(madperson)

(In reply to Roland Tanglao :rolandtanglao from comment #14)

> :elan: I think :philipp is simply asking Damira to re-test with a localized
> e.g. German Firefox 53 desktop build with a new *new Firefox profile*. No
> need to flip the pref. Right :philipp?

As you requested I installed German Firefox 53 build and tested with new profile.
The result is the same as in the description.

links i've tested:
* (?) on top right of about:preferences -> https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/prefs-main
* "Weitere Informationen..." button on https://expired.badssl.com/ -> https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/time-errors
* menu bar > Hilfe > Tastenkobinationen -> https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/keyboard-shortcuts
* "Weitere Informationen" on top of about:plugins -> https://support.mozilla.org/1/firefox/53.0/WINNT/de/npapi

all these links end up on the english sumo homepage at https://support.mozilla.org/t5/Mozilla-Support-English/ct-p/Mozilla-EN
:phillip Accept-Language headers are not working at the moment. We have an enhancement request in to Lithium part of which will allow accept-language headers to be recognized.

Below is the URL spec that is a combination of input from the Firefox and Lithium devs.
URLs from :philipp above

https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/prefs-main - this slug was not in our spreadsheet that was submitted to Lithium

https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/time-errors - this slug was not in our spreadsheet that was submitted to Lithium

https://support.mozilla.org/1/firefox/54.0a2/WINNT/de/keyboard-shortcuts - Goes to a REDIRECT page. Lithium will fix with their current SoW.

https://support.mozilla.org/1/firefox/53.0/WINNT/de/npapi - This URL was submitted to Lithium and the Redirect is working from https://support.mozilla.org/kb/npapi-plugins-de but not from https://support.mozilla.org/1/firefox/53.0/WINNT/de/npapi
probably most to all in-product support links have this format: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/slug (that's predefined in app.support.baseURL)
Philipp, The NI for me is invalid at this point since we have done the roll back. I'll leave it to you as the originator of this ticket to decide what you want to do with it. Thank you!
Flags: needinfo?(elancaster) → needinfo?(madperson)
i'll close the bug for now as things are fine on kitsune & will revisit the issue once there's another attempt to switch to lithium.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(madperson)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: