Avoid concat in Sqlite.jsm::bindParam

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [fxsearch][photon-performance])

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The concat call in bindParam appears in some profiles, it is not strictly needed in the most common cases, so let's avoid it.

Updated

2 years ago
Flags: qe-verify?
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8858014 [details]
Bug 1356284 - Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam.

https://reviewboard.mozilla.org/r/130048/#review132678
Attachment #8858014 - Flags: review?(florian) → review+

Comment 3

2 years ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/e8e2593692a5
Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam. r=florian

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e8e2593692a5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

2 years ago
Iteration: --- → 55.3 - Apr 17

Updated

2 years ago
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.