Closed Bug 1356284 Opened 7 years ago Closed 7 years ago

Avoid concat in Sqlite.jsm::bindParam

Categories

(Toolkit :: Storage, defect, P1)

Product:
Toolkit
Component:
Storage
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Iteration:
55.3 - Apr 17
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch][photon-performance])

Attachments

(1 file)

Bug 1356284 - Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam.
59 bytes, text/x-review-board-request
florian
: review+
Details 
The concat call in bindParam appears in some profiles, it is not strictly needed in the most common cases, so let's avoid it.
Flags: qe-verify?
Comment on attachment 8858014 [details]
Bug 1356284 - Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam.

https://reviewboard.mozilla.org/r/130048/#review132678
Attachment #8858014 - Flags: review?(florian) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/e8e2593692a5
Avoid a not strictly needed but expensive concat in Sqlite.jsm::bindParam. r=florian
https://hg.mozilla.org/mozilla-central/rev/e8e2593692a5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Iteration: --- → 55.3 - Apr 17
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.