1356285 - micro-optimization in richlistbox selectedIndex setter

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, enhancement, P1)

Description

[Marco Bonardo [:mak]]

Setting selectedIndex invokes selectItem, that sets currentItem and then invokes _fireOnSelect.
The richlistbox version of _fireOnSelect queries .currentIndex, that does getIndexOfItem(this.currentItem) that has to iterate all the children.

Since we just set the index, we already know it!

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1356285 - micro-optimization in richlistbox selectedIndex setter.

Review commit: https://reviewboard.mozilla.org/r/130072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130072/

Comment 2

[Neil Deakin]

Comment on attachment 8858105 [details]
Bug 1356285 - micro-optimization in richlistbox selectedIndex setter.

https://reviewboard.mozilla.org/r/130072/#review133456

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ae37bdf2bbf
micro-optimization in richlistbox selectedIndex setter. r=enndeakin+6102

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ae37bdf2bbf