Closed
Bug 1356285
Opened 7 years ago
Closed 7 years ago
micro-optimization in richlistbox selectedIndex setter
Categories
(Toolkit :: UI Widgets, enhancement, P1)
Toolkit
UI Widgets
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [fxsearch][photon-performance])
Attachments
(1 file)
Setting selectedIndex invokes selectItem, that sets currentItem and then invokes _fireOnSelect. The richlistbox version of _fireOnSelect queries .currentIndex, that does getIndexOfItem(this.currentItem) that has to iterate all the children. Since we just set the index, we already know it!
|
||
Updated•7 years ago
|
Flags: qe-verify?
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8858105 -
Flags: review?(enndeakin)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8858105 [details] Bug 1356285 - micro-optimization in richlistbox selectedIndex setter. https://reviewboard.mozilla.org/r/130072/#review133456
Attachment #8858105 -
Flags: review?(enndeakin) → review+
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/0ae37bdf2bbf micro-optimization in richlistbox selectedIndex setter. r=enndeakin+6102
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0ae37bdf2bbf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
|
||
Updated•7 years ago
|
Iteration: --- → 55.4 - May 1
|
|
||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•