1356314 - switch antenna to mozlog format [antenna]

Status: RESOLVED FIXED

(Socorro :: Antenna, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently, Antenna generates logs using the Python logging module with an unstructured format. This worked super for development and even getting us to production, but it doesn't jive with downstream systems that require a more structured logging format.

This issue covers switching Antenna to use mozlog format.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'll look at doing this. We're going to need to do the same with the processor. Might as well do it next.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Dropping this here as a possibility: http://mozbase.readthedocs.io/en/latest/loggingreporting.html

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Switching Antenna bugs to Antenna component.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Found a better library that uses the Python logging infrastructure:

https://github.com/mozilla/mozilla-cloud-services-logger

That library could use a little help, so I'll probably spend a few hours to fix some issues and then use that.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Turns out mozilla-cloud-services-logger is abandoned and that there's a **third** mozlog implementation!

python-dockerflow is the appropriate library to use. It says it's a Django lib, but it's not. Normandy is switching to that soon. We should use that, too.

However, we should spend some time helping hem out first. I wrote up this issue:

https://github.com/mozilla-services/python-dockerflow/issues/12

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

The code for it is here: https://github.com/mozilla-services/python-dockerflow/blob/master/src/dockerflow/logging.py

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: Link to Github pull-request: https://github.com/mozilla/antenna/pull/227

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Had to fix the host id filter: https://github.com/mozilla/antenna/pull/230

All that's landed. Just need to deploy it.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is done. Marking as FIXED.